Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back loading chunks for sourcemap tracing #61790

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Feb 7, 2024

This implements falling back to try multiple locations loading chunks for sourcemap tracing.

Unfortunately, when RSC replays server errors on the client, it does not carry over the [0] symbol used to annotate server frames. Instead, errors are recreated by React and only include the message and stack.

This allows more tests to pass, as we are able to correctly trace stack frames by loading the appropriate server chunk.

Closes PACK-2442

This implements a basic test for determining if a stack frame originated on the server.

Unfortunately, when RSC replays server errors on the client, it does not carry over the [0] symbol used to annotate server frames. Instead, errors are recreated by React and only include the message and stack.

This allows more tests to pass, as we are able to correctly trace stack frames by loading the appropriate server chunk.

https://github.com/vercel/next.js/blob/13af19a5627f2e2e538e9db9a6bfa0d13f216a72/packages/react-dev-overlay/src/internal/helpers/nodeStackFrames.ts#L33-L41
@ijjk
Copy link
Member

ijjk commented Feb 7, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
buildDuration 13.6s 13.7s N/A
buildDurationCached 7.6s 7s N/A
nodeModulesSize 318 MB 318 MB
nextStartRea..uration (ms) 486ms 485ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB N/A
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.5 kB 29.5 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 46.9 kB 46.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 501 B N/A
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.22 kB 4.21 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 106 B 106 B
Client Build Manifests
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
index.html gzip 526 B 526 B
link.html gzip 541 B 539 B N/A
withRouter.html gzip 521 B 521 B
Overall change 1.05 kB 1.05 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
middleware-b..fest.js gzip 622 B 624 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 47.4 kB 47.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 1.94 kB 1.94 kB
Next Runtimes
vercel/next.js canary vercel/next.js wbinnssmith/stack-frame-server Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.1 kB 95.1 kB
app-page-tur..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 91.5 kB 91.5 kB
app-page.run...dev.js gzip 135 kB 135 kB
app-page.run..prod.js gzip 90 kB 90 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 922 kB 922 kB
Commit: 334704e

@wbinnssmith wbinnssmith changed the title Correctly tag stack frames as server frames Fall back loading chunks for sourcemap tracing Feb 8, 2024
@ijjk
Copy link
Member

ijjk commented Feb 8, 2024

Tests Passed

@timneutkens timneutkens merged commit 50ef635 into canary Feb 8, 2024
69 checks passed
@timneutkens timneutkens deleted the wbinnssmith/stack-frame-server branch February 8, 2024 08:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants