-
Notifications
You must be signed in to change notification settings - Fork 26.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall back loading chunks for sourcemap tracing #61790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a basic test for determining if a stack frame originated on the server. Unfortunately, when RSC replays server errors on the client, it does not carry over the [0] symbol used to annotate server frames. Instead, errors are recreated by React and only include the message and stack. This allows more tests to pass, as we are able to correctly trace stack frames by loading the appropriate server chunk. https://github.com/vercel/next.js/blob/13af19a5627f2e2e538e9db9a6bfa0d13f216a72/packages/react-dev-overlay/src/internal/helpers/nodeStackFrames.ts#L33-L41
wbinnssmith
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
February 7, 2024 21:01
ijjk
added
area: tests
created-by: Turbopack team
PRs by the turbopack team
type: next
labels
Feb 7, 2024
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
wbinnssmith
changed the title
Correctly tag stack frames as server frames
Fall back loading chunks for sourcemap tracing
Feb 8, 2024
Tests Passed |
kdy1
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements falling back to try multiple locations loading chunks for sourcemap tracing.
Unfortunately, when RSC replays server errors on the client, it does not carry over the [0] symbol used to annotate server frames. Instead, errors are recreated by React and only include the message and stack.
This allows more tests to pass, as we are able to correctly trace stack frames by loading the appropriate server chunk.
Closes PACK-2442