Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(analysis): rust based page-static-info, deprecate js parse interface in next-swc #61832

Merged
merged 6 commits into from
Mar 4, 2024
Merged

refactor(analysis): rust based page-static-info, deprecate js parse interface in next-swc #61832

merged 6 commits into from
Mar 4, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Feb 8, 2024 •
edited

Reenabling #59300 with fixes for the unsupported inputs.

Closes PACK-2088

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Feb 8, 2024
@ijjk
Copy link
Member

ijjk commented Feb 8, 2024 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
buildDuration 11.8s 14s ⚠️ +2.2s
buildDurationCached 7.5s 6.5s N/A
nodeModulesSize 197 MB 197 MB N/A
nextStartRea..uration (ms) 430ms 419ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
8930-HASH.js gzip 30.2 kB 30.2 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 222 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.56 kB 6.56 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
page.js gzip 933 B 3.08 kB ⚠️ +2.15 kB
edge-ssr.js gzip N/A 95 kB N/A
Overall change 933 B 3.08 kB ⚠️ +2.15 kB
Middleware size
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.4 kB 25.5 kB N/A
edge-runtime..pack.js gzip 786 B 839 B N/A
Overall change 151 B 151 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 96.7 kB 96.7 kB ✓
app-page-tur..prod.js gzip 98.5 kB 98.5 kB ✓
app-page-tur..prod.js gzip 92.9 kB 92.9 kB ✓
app-page.run...dev.js gzip 150 kB 150 kB ✓
app-page.run..prod.js gzip 91.4 kB 91.4 kB ✓
app-route-ex...dev.js gzip 21.3 kB 21.3 kB ✓
app-route-ex..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 20.9 kB 20.9 kB ✓
app-route.ru..prod.js gzip 14.7 kB 14.7 kB ✓
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB ✓
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB ✓
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 23 kB 23 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.6 kB 50.6 kB ✓
Overall change 950 kB 950 kB ✓
build cache
vercel/next.js canary vercel/next.js refactor-parse-module-redux Change
0.pack gzip 1.99 MB 1.56 MB N/A
index.pack gzip 118 kB 105 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for page.js

Diff too large to display

Diff for edge-runtime-webpack.js 
@@ -102,6 +102,21 @@
     /******/
   })();
   /******/
+  /******/ /* webpack/runtime/compat get default export */
+  /******/ (() => {
+    /******/ // getDefaultExport function for compatibility with non-harmony modules
+    /******/ __webpack_require__.n = (module) => {
+      /******/ var getter =
+        module && module.__esModule
+          ? /******/ () => module["default"]
+          : /******/ () => module;
+      /******/ __webpack_require__.d(getter, { a: getter });
+      /******/ return getter;
+      /******/
+    };
+    /******/
+  })();
+  /******/
   /******/ /* webpack/runtime/define property getters */
   /******/ (() => {
     /******/ // define getter functions for harmony exports
@@ -124,6 +139,15 @@
     /******/
   })();
   /******/
+  /******/ /* webpack/runtime/ensure chunk */
+  /******/ (() => {
+    /******/ // The chunk loading function for additional chunks
+    /******/ // Since all referenced chunks are already included
+    /******/ // in this file, this function is empty here.
+    /******/ __webpack_require__.e = () => Promise.resolve();
+    /******/
+  })();
+  /******/
   /******/ /* webpack/runtime/global */
   /******/ (() => {
     /******/ __webpack_require__.g = (function () {
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 8930-HASH.js

Diff too large to display

Diff for main-app-HASH.js 
@@ -1,28 +1,40 @@
 (self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
   [1744],
   {
-    /***/ 8938: /***/ function (
+    /***/ 3622: /***/ function (
       __unused_webpack_module,
       __unused_webpack_exports,
       __webpack_require__
     ) {
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.t.bind(__webpack_require__, 3880, 23)
+        __webpack_require__.t.bind(__webpack_require__, 9832, 23)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.t.bind(__webpack_require__, 9489, 23)
+        __webpack_require__.t.bind(__webpack_require__, 7756, 23)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.t.bind(__webpack_require__, 8247, 23)
+        __webpack_require__.t.bind(__webpack_require__, 7409, 23)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.t.bind(__webpack_require__, 7769, 23)
+        __webpack_require__.t.bind(__webpack_require__, 3711, 23)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.t.bind(__webpack_require__, 287, 23)
+        __webpack_require__.t.bind(__webpack_require__, 8725, 23)
       );
       Promise.resolve(/* import() eager */).then(
-        __webpack_require__.t.bind(__webpack_require__, 5070, 23)
+        __webpack_require__.t.bind(__webpack_require__, 615, 23)
+      );
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 3035, 23)
+      );
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 8456, 23)
+      );
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.bind(__webpack_require__, 2499)
+      );
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 162, 23)
       );
 
       /***/
@@ -33,8 +45,8 @@
     /******/ var __webpack_exec__ = function (moduleId) {
       return __webpack_require__((__webpack_require__.s = moduleId));
     };
-    /******/ __webpack_require__.O(0, [1904, 8930], function () {
-      return __webpack_exec__(733), __webpack_exec__(8938);
+    /******/ __webpack_require__.O(0, [5658, 6901], function () {
+      return __webpack_exec__(1428), __webpack_exec__(3622);
     });
     /******/ var __webpack_exports__ = __webpack_require__.O();
     /******/ _N_E = __webpack_exports__;
Commit: 1e510bd

@kwonoj kwonoj force-pushed the refactor-parse-module-redux branch from a736e1c to a680c58 Compare February 8, 2024 19:58
@kwonoj kwonoj changed the title WIP refactor(analysis): rust based page-static-info, deprecate js parse interface in next-swc Feb 8, 2024
@kwonoj kwonoj marked this pull request as ready for review February 8, 2024 20:17
@kwonoj kwonoj force-pushed the refactor-parse-module-redux branch 3 times, most recently from 9f4e3ac to 079764c Compare February 14, 2024 17:26
@ijjk
Copy link
Member

ijjk commented Feb 14, 2024 •
edited

Tests Passed

ForsakenHarmony
ForsakenHarmony reviewed Feb 16, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
packages/next-swc/crates/napi/Cargo.toml Outdated Show resolved Hide resolved
@sokra
Copy link
Member

sokra commented Mar 1, 2024

Needs a rebase

@kwonoj kwonoj force-pushed the refactor-parse-module-redux branch from 7a86f08 to 254d2a7 Compare March 1, 2024 22:13
@kwonoj kwonoj force-pushed the refactor-parse-module-redux branch from 6d1665f to 7872a50 Compare March 2, 2024 00:34
@kwonoj kwonoj merged commit 372c74b into canary Mar 4, 2024
64 of 69 checks passed
@kwonoj kwonoj deleted the refactor-parse-module-redux branch March 4, 2024 16:07
@kwonoj kwonoj mentioned this pull request Mar 4, 2024
Merged
ijjk pushed a commit that referenced this pull request Mar 4, 2024
@kwonoj
Revert "refactor(analysis): rust based page-static-info, deprecate js…
655227f 
… parse interface in next-swc" (#62838)

Reverts #61832

Closes PACK-2654
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra left review comments

@ForsakenHarmony ForsakenHarmony ForsakenHarmony left review comments

@kdy1 kdy1 kdy1 left review comments

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kwonoj @ijjk @sokra @timneutkens @ForsakenHarmony @kdy1