fix(custom-transform): allow to assert empty program for rsc #61922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
ijjk
added
Turbopack
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
Diff detailsDiff for page.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display Diff for image-HASH.js@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[358],
{
- /***/ 1552: /***/ function (
+ /***/ 4070: /***/ function (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(2599);
+ return __webpack_require__(2369);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 9272: /***/ function (module, exports, __webpack_require__) {
+ /***/ 3299: /***/ function (module, exports, __webpack_require__) {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -40,15 +40,15 @@
__webpack_require__(422)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(8286)
+ __webpack_require__(4830)
);
- const _getimgprops = __webpack_require__(985);
- const _imageconfig = __webpack_require__(8749);
- const _imageconfigcontextsharedruntime = __webpack_require__(7829);
- const _warnonce = __webpack_require__(3652);
- const _routercontextsharedruntime = __webpack_require__(6120);
+ const _getimgprops = __webpack_require__(3301);
+ const _imageconfig = __webpack_require__(2958);
+ const _imageconfigcontextsharedruntime = __webpack_require__(6869);
+ const _warnonce = __webpack_require__(2179);
+ const _routercontextsharedruntime = __webpack_require__(7554);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5732)
+ __webpack_require__(9687)
);
// This is replaced by webpack define plugin
const configEnv = {
@@ -69,8 +69,7 @@
onLoadRef,
onLoadingCompleteRef,
setBlurComplete,
- unoptimized,
- sizesInput
+ unoptimized
) {
const src = img == null ? void 0 : img.src;
if (!img || img["data-loaded-src"] === src) {
@@ -166,7 +165,6 @@
onLoadingCompleteRef,
setBlurComplete,
setShowAltText,
- sizesInput,
onLoad,
onError,
...rest
@@ -221,8 +219,7 @@
onLoadRef,
onLoadingCompleteRef,
setBlurComplete,
- unoptimized,
- sizesInput
+ unoptimized
);
}
},
@@ -234,7 +231,6 @@
setBlurComplete,
onError,
unoptimized,
- sizesInput,
forwardedRef,
]
),
@@ -246,8 +242,7 @@
onLoadRef,
onLoadingCompleteRef,
setBlurComplete,
- unoptimized,
- sizesInput
+ unoptimized
);
},
onError: (event) => {
@@ -351,7 +346,6 @@
onLoadingCompleteRef: onLoadingCompleteRef,
setBlurComplete: setBlurComplete,
setShowAltText: setShowAltText,
- sizesInput: props.sizes,
ref: forwardedRef,
}),
imgMeta.priority
@@ -379,7 +373,7 @@
/***/
},
- /***/ 985: /***/ function (
+ /***/ 3301: /***/ function (
__unused_webpack_module,
exports,
__webpack_require__
@@ -395,9 +389,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(3652);
- const _imageblursvg = __webpack_require__(1668);
- const _imageconfig = __webpack_require__(8749);
+ const _warnonce = __webpack_require__(2179);
+ const _imageblursvg = __webpack_require__(892);
+ const _imageconfig = __webpack_require__(2958);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -766,7 +760,7 @@
/***/
},
- /***/ 1668: /***/ function (__unused_webpack_module, exports) {
+ /***/ 892: /***/ function (__unused_webpack_module, exports) {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -821,7 +815,7 @@
/***/
},
- /***/ 9582: /***/ function (
+ /***/ 3612: /***/ function (
__unused_webpack_module,
exports,
__webpack_require__
@@ -848,10 +842,10 @@
},
});
const _interop_require_default = __webpack_require__(2430);
- const _getimgprops = __webpack_require__(985);
- const _imagecomponent = __webpack_require__(9272);
+ const _getimgprops = __webpack_require__(3301);
+ const _imagecomponent = __webpack_require__(3299);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5732)
+ __webpack_require__(9687)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -883,7 +877,7 @@
/***/
},
- /***/ 5732: /***/ function (__unused_webpack_module, exports) {
+ /***/ 9687: /***/ function (__unused_webpack_module, exports) {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -918,7 +912,7 @@
/***/
},
- /***/ 2599: /***/ function (
+ /***/ 2369: /***/ function (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -939,8 +933,8 @@
// EXTERNAL MODULE: ./node_modules/.pnpm/react@18.2.0/node_modules/react/jsx-runtime.js
var jsx_runtime = __webpack_require__(1527);
- // EXTERNAL MODULE: ./node_modules/.pnpm/file+..+main-repo+packages+next+next-packed.tgz_react-dom@18.2.0_react@18.2.0/node_modules/next/image.js
- var next_image = __webpack_require__(1577);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/file+..+diff-repo+packages+next+next-packed.tgz_react-dom@18.2.0_react@18.2.0/node_modules/next/image.js
+ var next_image = __webpack_require__(73);
var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
/* harmony default export */ var nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
@@ -970,12 +964,12 @@
/***/
},
- /***/ 1577: /***/ function (
+ /***/ 73: /***/ function (
module,
__unused_webpack_exports,
__webpack_require__
) {
- module.exports = __webpack_require__(9582);
+ module.exports = __webpack_require__(3612);
/***/
},
@@ -986,7 +980,7 @@
return __webpack_require__((__webpack_require__.s = moduleId));
};
/******/ __webpack_require__.O(0, [888, 774, 179], function () {
- return __webpack_exec__(1552);
+ return __webpack_exec__(4070);
});
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for 68-HASH.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsDiff too large to display Diff for app-page-exp..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page.runtime.dev.jsDiff too large to display Diff for app-page.runtime.prod.jsDiff too large to display Diff for app-route-ex..ntime.dev.jsDiff too large to display Diff for app-route-ex..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route.runtime.dev.jsDiff too large to display Diff for app-route.ru..time.prod.jsDiff too large to display Diff for pages-turbo...time.prod.jsDiff too large to display Diff for pages.runtime.dev.jsDiff too large to display Diff for pages.runtime.prod.jsDiff too large to display Diff for server.runtime.prod.jsDiff too large to display |
|
Should we fix that in Turbopack to always use a |
Yes, about to ask kdy to confirm actually - didn't ping him since it's holiday. PR shoudn't be checked in until then. |
kdy1
reviewed
Feb 13, 2024
packages/next-swc/crates/next-custom-transforms/src/transforms/react_server_components.rs
Outdated
Show resolved
Hide resolved
kwonoj
force-pushed
the
fix-empty-program-rsc-validation
branch
from
c321197
to
4fd90e9
Compare
Tests Passed |
wbinnssmith
approved these changes
Feb 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Turbopack uses
parse_as_prorgram, and in case of empty file it returns script instead of module so none of visitor runs for the rsc module.This PR attempts to workaround, however need double clarification if upstream swc behavior is desired.
Closes PACK-2460