Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update swc_core to v0.90.8 #61976

Merged
merged 4 commits into from
Feb 14, 2024
Merged

build: Update swc_core to v0.90.8 #61976

merged 4 commits into from
Feb 14, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 13, 2024

What?

Update swc crates one more time.

Why?

To apply swc-project/plugins#267

How?

Fixes #61788

Closes PACK-2446
Closes PACK-2476

@ijjk ijjk added the created-by: Turbopack team PRs by the turbopack team label Feb 13, 2024
@ijjk
Copy link
Member

ijjk commented Feb 13, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
buildDuration 19.1s 19.1s N/A
buildDurationCached 6.9s 6.1s N/A
nodeModulesSize 196 MB 196 MB
nextStartRea..uration (ms) 431ms 429ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
1068-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 4.96 kB 4.96 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32 kB 32 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 525 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
edge-ssr.js gzip 94.4 kB 94.4 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
middleware-b..fest.js gzip 625 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 44.4 kB 44.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.1 kB 2.1 kB
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.5 kB 95.5 kB
app-page-tur..prod.js gzip 97.2 kB 97.2 kB
app-page-tur..prod.js gzip 91.7 kB 91.7 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22.1 kB 22.1 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22.1 kB 22.1 kB
server.runti..prod.js gzip 49.9 kB 49.9 kB
Overall change 925 kB 925 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/swc-core-0-90-2 Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 103 kB 103 kB ⚠️ +293 B
Overall change 103 kB 103 kB ⚠️ +293 B
Commit: 6ef3d8e

@ijjk
Copy link
Member

ijjk commented Feb 13, 2024

Failing test suites

Commit: 2248ee7

pnpm test test/integration/edge-runtime-configurable-guards/test/index.test.js

  • Edge runtime configurable guards > Multiple functions with different configurations > warns in dev for allowed code
Expand output

● Edge runtime configurable guards › Multiple functions with different configurations › warns in dev for allowed code

expect(received).toContain(expected) // indexOf

Expected substring: "Dynamic Code Evaluation (e. g. 'eval', 'new Function') not allowed in Edge Runtime"
Received string:    "   ▲ Next.js 14.1.1-canary.52
   - Local:        http://localhost:42323·
 ⨯ Middleware cannot be used with \"output: export\". See more info here: https://nextjs.org/docs/advanced-features/static-html-export
 ⨯ API Routes cannot be used with \"output: export\". See more info here: https://nextjs.org/docs/advanced-features/static-html-export
 ✓ Ready in 1245ms
 ○ Compiling / ...
 ✓ Compiled / in 727ms (196 modules)
"

  86 |       expect(res.status).toBe(200)
  87 |       await retry(async () => {
> 88 |         expect(context.logs.output).toContain(
     |                                     ^
  89 |           `Dynamic Code Evaluation (e. g. 'eval', 'new Function') not allowed in Edge Runtime`
  90 |         )
  91 |       })

  at toContain (integration/edge-runtime-configurable-guards/test/index.test.js:88:37)
  at fn (lib/next-test-utils.ts:724:20)
  at Object.<anonymous> (integration/edge-runtime-configurable-guards/test/index.test.js:87:7)

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 enabled auto-merge (squash) February 14, 2024 02:17
kdy1 added a commit to vercel/turbo that referenced this pull request Feb 14, 2024
### Description

Update swc crates one more time.

### Testing Instructions

See vercel/next.js#61976

Closes PACK-2477
@kdy1 kdy1 disabled auto-merge February 14, 2024 06:33
@kdy1 kdy1 enabled auto-merge (squash) February 14, 2024 06:36
@kdy1 kdy1 merged commit 24f9812 into canary Feb 14, 2024
71 checks passed
@kdy1 kdy1 deleted the kdy1/swc-core-0-90-2 branch February 14, 2024 07:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable expansions for media queries inside styled-jsx break with Turbopack
3 participants