add turbo.resolveExtensions to allow to customize extensions #62004

sokra · 2024-02-13T16:45:45Z

What?

add turbo.resolveExtensions to allow to customize extensions in Turbopack

ijjk · 2024-02-13T16:56:06Z

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
buildDuration	19.9s	19.8s	N/A
buildDurationCached	8.5s	6.9s	N/A
nodeModulesSize	196 MB	196 MB	⚠️ +1.14 kB
nextStartRea..uration (ms)	428ms	438ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
1068-HASH.js gzip	30.3 kB	30.3 kB	N/A
3f784ff6-HASH.js gzip	53.5 kB	53.5 kB	N/A
4944-HASH.js gzip	5.04 kB	5.03 kB	N/A
8423.HASH.js gzip	181 B	181 B	✓
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	241 B	✓
main-HASH.js gzip	32.1 kB	32.1 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	47.3 kB	47.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
_app-HASH.js gzip	196 B	196 B	✓
_error-HASH.js gzip	184 B	183 B	N/A
amp-HASH.js gzip	503 B	504 B	N/A
css-HASH.js gzip	323 B	324 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.51 kB	N/A
edge-ssr-HASH.js gzip	258 B	259 B	N/A
head-HASH.js gzip	353 B	351 B	N/A
hooks-HASH.js gzip	370 B	370 B	✓
image-HASH.js gzip	4.21 kB	4.2 kB	N/A
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.68 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	313 B	314 B	N/A
script-HASH.js gzip	386 B	385 B	N/A
withRouter-HASH.js gzip	309 B	311 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	931 B	931 B	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
_buildManifest.js gzip	485 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
index.html gzip	528 B	528 B	✓
link.html gzip	540 B	541 B	N/A
withRouter.html gzip	524 B	523 B	N/A
Overall change	528 B	528 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
edge-ssr.js gzip	94.5 kB	94.5 kB	N/A
page.js gzip	151 kB	151 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
middleware-b..fest.js gzip	627 B	627 B	✓
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	44.6 kB	44.6 kB	N/A
edge-runtime..pack.js gzip	1.94 kB	1.94 kB	✓
Overall change	2.72 kB	2.72 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
app-page-exp...dev.js gzip	166 kB	166 kB	✓
app-page-exp..prod.js gzip	95.9 kB	95.9 kB	✓
app-page-tur..prod.js gzip	97.6 kB	97.6 kB	✓
app-page-tur..prod.js gzip	92 kB	92 kB	✓
app-page.run...dev.js gzip	136 kB	136 kB	✓
app-page.run..prod.js gzip	90.6 kB	90.6 kB	✓
app-route-ex...dev.js gzip	22 kB	22 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.6 kB	14.6 kB	✓
app-route.ru...dev.js gzip	21.7 kB	21.7 kB	✓
app-route.ru..prod.js gzip	14.6 kB	14.6 kB	✓
pages-api-tu..prod.js gzip	9.47 kB	9.47 kB	✓
pages-api.ru...dev.js gzip	9.74 kB	9.74 kB	✓
pages-api.ru..prod.js gzip	9.47 kB	9.47 kB	✓
pages-turbo...prod.js gzip	22.1 kB	22.1 kB	✓
pages.runtim...dev.js gzip	22.7 kB	22.7 kB	✓
pages.runtim..prod.js gzip	22.1 kB	22.1 kB	✓
server.runti..prod.js gzip	50.1 kB	50.1 kB	✓
Overall change	927 kB	927 kB	✓

build cache

	vercel/next.js canary	vercel/next.js sokra/resolve-extensions	Change
0.pack gzip	1.55 MB	1.55 MB	N/A
index.pack gzip	104 kB	103 kB	N/A
Overall change	0 B	0 B	✓

Commit: 88768e7

ijjk · 2024-02-13T16:56:46Z

Failing test suites

Commit: 88768e7

pnpm test test/integration/preload-viewport/test/index.test.js

Prefetching Links in viewport > production mode > should prefetch with non-bot UA

Expand output

● Prefetching Links in viewport › production mode › should prefetch with non-bot UA

expect(received).toHaveLength(expected)

Expected length: 1
Received length: 0
Received array:  []

  129 |         )
  130 |         const links = await browser.elementsByCss('link[rel=prefetch]')
> 131 |         expect(links).toHaveLength(1)
      |                       ^
  132 |       } finally {
  133 |         if (browser) await browser.close()
  134 |       }

  at Object.toHaveLength (integration/preload-viewport/test/index.test.js:131:23)

Read more about building and testing Next.js in contributing.md.

ForsakenHarmony · 2024-02-15T00:48:53Z

test/e2e/app-dir/turbo-resolve-extensions/next.config.js

+  turbo: {
+    resolveExtensions: ['png', 'tsx', 'ts', 'jsx', 'js', 'json'],
+  },
+  webpack(config) {
+    config.resolve.extensions = ['.png', '.tsx', '.ts', '.jsx', '.js', '.json']
+    return config
+  },


Can we just have a shared field both can read from?

yes. It's only a test case

no, I meant have a field in next.config.js which both turbopack and webpack read from

not in this test, but in general

e.g. experimental.resolveExtensions for now and read that in build/webpack-config.ts as well

I think it would be better to introduce an option that you don't need to add twice

ijjk added area: documentation Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Feb 13, 2024

ForsakenHarmony reviewed Feb 15, 2024

View reviewed changes

sokra added 2 commits February 15, 2024 14:16

add turbo.resolveExtensions to allow to customize extensions

dc6fbc6

update turbopack

2407c7b

sokra force-pushed the sokra/resolve-extensions branch from 1b49110 to 2407c7b Compare February 15, 2024 14:17

share list

a9a4849

sokra marked this pull request as ready for review February 15, 2024 14:21

sokra requested review from timneutkens, ijjk, shuding, huozhi, a team, styfle, ztanner, feedthejim and wyattjoh as code owners February 15, 2024 14:21

sokra requested review from timeyoutakeit, StephDietz and ForsakenHarmony and removed request for a team February 15, 2024 14:21

sokra enabled auto-merge (squash) February 15, 2024 14:21

Merge branch 'canary' into sokra/resolve-extensions

26d1e1c

sokra added 7 commits February 15, 2024 20:38

Merge branch 'canary' into sokra/resolve-extensions

43a7e23

Merge branch 'canary' into sokra/resolve-extensions

cef6acf

fixup typos

c99208a

rename test case

d96cf7d

do not apply resolveExtensions to foreign code

99abf29

fix test case

de2a95e

Merge branch 'canary' into sokra/resolve-extensions

88768e7

timneutkens approved these changes Feb 19, 2024

View reviewed changes

sokra merged commit 8250a84 into canary Feb 19, 2024
70 checks passed

sokra deleted the sokra/resolve-extensions branch February 19, 2024 09:07

github-actions bot added the locked label Mar 4, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add turbo.resolveExtensions to allow to customize extensions #62004

add turbo.resolveExtensions to allow to customize extensions #62004

sokra commented Feb 13, 2024 •

edited by ForsakenHarmony

ijjk commented Feb 13, 2024 •

edited

ijjk commented Feb 13, 2024 •

edited

ForsakenHarmony Feb 15, 2024

sokra Feb 15, 2024

ForsakenHarmony Feb 15, 2024 •

edited

ForsakenHarmony Feb 16, 2024

ForsakenHarmony Feb 16, 2024

add turbo.resolveExtensions to allow to customize extensions #62004

add turbo.resolveExtensions to allow to customize extensions #62004

Conversation

sokra commented Feb 13, 2024 • edited by ForsakenHarmony

What?

ijjk commented Feb 13, 2024 • edited

Stats from current PR

ijjk commented Feb 13, 2024 • edited

Failing test suites

ForsakenHarmony Feb 15, 2024

Choose a reason for hiding this comment

sokra Feb 15, 2024

Choose a reason for hiding this comment

ForsakenHarmony Feb 15, 2024 • edited

Choose a reason for hiding this comment

ForsakenHarmony Feb 16, 2024

Choose a reason for hiding this comment

ForsakenHarmony Feb 16, 2024

Choose a reason for hiding this comment

sokra commented Feb 13, 2024 •

edited by ForsakenHarmony

ijjk commented Feb 13, 2024 •

edited

ijjk commented Feb 13, 2024 •

edited

ForsakenHarmony Feb 15, 2024 •

edited