Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory/cache overhead from over loader processing #62005

Merged
merged 11 commits into from
Feb 13, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 13, 2024

In v14.0.2-canary.1 users started noticing more memory errors especially with many edge runtime configured pages. After investigation it seems this can be related to the additional transpiling we configured in #59569 and #57784

To help alleviate this we are updating the default swc loader to have an additional check to see if no special features such as next/font, next/dynamic, or use server/client directives are present and then no-oping in the loader to avoid additional overhead for a majority of modules.

For monitoring regressions our stats-app has been updated with repeated edge-ssr routes to hopefully help us keep an eye on memory or cache size issues.

x-ref: NEXT-2430
x-ref: NEXT-2395
x-ref: NEXT-2299
x-ref: NEXT-2324
x-ref: NEXT-2373

Closes NEXT-2479

@ijjk
Copy link
Member Author

ijjk commented Feb 13, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
buildDuration 21.9s 21.1s N/A
buildDurationCached 7.9s 7.2s N/A
nodeModulesSize 196 MB 196 MB ⚠️ +9.35 kB
nextStartRea..uration (ms) 440ms 439ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
1068-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 4.96 kB 4.96 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32 kB 32 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
index.html gzip 528 B 528 B
link.html gzip 539 B 539 B
withRouter.html gzip 524 B 521 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
edge-ssr.js gzip 94.4 kB 94.4 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
middleware-b..fest.js gzip 625 B 628 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 47.4 kB 44.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.1 kB 2.1 kB
Next Runtimes
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.5 kB 95.5 kB
app-page-tur..prod.js gzip 97.2 kB 97.2 kB
app-page-tur..prod.js gzip 91.7 kB 91.7 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22.1 kB 22.1 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22.1 kB 22.1 kB
server.runti..prod.js gzip 49.9 kB 49.9 kB
Overall change 925 kB 925 kB
build cache Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/exclude-conditions Change
0.pack gzip 1.64 MB 1.54 MB N/A
index.pack gzip 62.3 kB 104 kB ⚠️ +41.2 kB
Overall change 62.3 kB 104 kB ⚠️ +41.2 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for 1068-HASH.js

Diff too large to display

Commit: c83a4bc

@@ -0,0 +1,115 @@
import Image from 'next/image'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are intentional to stress test compiling numerous edge app routes.

@ijjk ijjk marked this pull request as ready for review February 13, 2024 20:39
@ijjk ijjk requested review from timeyoutakeit and delbaoliveira and removed request for a team February 13, 2024 20:40
@ijjk ijjk requested a review from huozhi February 13, 2024 21:47
@ijjk
Copy link
Member Author

ijjk commented Feb 13, 2024

Tests Passed

@ijjk ijjk enabled auto-merge (squash) February 13, 2024 22:35
@ijjk ijjk merged commit 49b4331 into vercel:canary Feb 13, 2024
69 checks passed
@ijjk ijjk deleted the update/exclude-conditions branch February 13, 2024 22:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants