docs(turbopack): reduce documentation size #62016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
kwonoj
requested review from
manovotny and
molebox
and removed request for
a team
ijjk
added
Font (next/font)
wbinnssmith
approved these changes
Feb 13, 2024
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
Tests Passed |
kwonoj
force-pushed
the
refactor-swc-core
branch
from
b730e19
to
b99b490
Compare
| @@ -48,7 +48,8 @@ pub use next_edge::context::{ | |||
| get_edge_chunking_context, get_edge_compile_time_info, get_edge_resolve_options_context, | |||
| }; | |||
| pub use page_loader::{create_page_loader_entry_module, PageLoaderAsset}; | |||
| pub use turbopack_binding::{turbopack::node::source_map, *}; | |||
| use turbopack_binding::turbo; | |||
| pub use turbopack_binding::{turbopack, turbopack::node::source_map}; | |||
There was a problem hiding this comment.
Where is this used?
Can we get rid of it?
There was a problem hiding this comment.
it is being imported by somewhere else, if I recall correctly next_build and another.
looks like using reexport from turbopack_binding is not great, I'll look further.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
next_core unexpectedly reexports everything, makes documentation size too large.
Closes PACK-2480