Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(next-core): do not reexport turbopack_binding #62018

Merged
merged 1 commit into from
Feb 14, 2024
Merged

refactor(next-core): do not reexport turbopack_binding #62018

merged 1 commit into from
Feb 14, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Feb 13, 2024 •
edited

What

Minor correction to the imports, turbopack_binding should not be reexported.

Closes PACK-2490

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Feb 13, 2024
@ijjk
Copy link
Member

ijjk commented Feb 13, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js refactor-reexport Change
buildDuration 19.1s 19s N/A
buildDurationCached 7s 6.1s N/A
nodeModulesSize 196 MB 196 MB ✓
nextStartRea..uration (ms) 427ms 428ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js refactor-reexport Change
1068-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 4.96 kB 4.96 kB N/A
8423.HASH.js gzip 181 B 181 B ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 241 B ✓
main-HASH.js gzip 32 kB 32 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 47.3 kB 47.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js refactor-reexport Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js refactor-reexport Change
_app-HASH.js gzip 196 B 196 B ✓
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B ✓
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 931 B 931 B ✓
Client Build Manifests
vercel/next.js canary vercel/next.js refactor-reexport Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js refactor-reexport Change
index.html gzip 528 B 528 B ✓
link.html gzip 539 B 539 B ✓
withRouter.html gzip 524 B 521 B N/A
Overall change 1.07 kB 1.07 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js refactor-reexport Change
edge-ssr.js gzip 94.4 kB 94.4 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js refactor-reexport Change
middleware-b..fest.js gzip 626 B 627 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 44.4 kB 44.4 kB ✓
edge-runtime..pack.js gzip 1.94 kB 1.94 kB ✓
Overall change 46.5 kB 46.5 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js refactor-reexport Change
app-page-exp...dev.js gzip 166 kB 166 kB ✓
app-page-exp..prod.js gzip 95.5 kB 95.5 kB ✓
app-page-tur..prod.js gzip 97.2 kB 97.2 kB ✓
app-page-tur..prod.js gzip 91.7 kB 91.7 kB ✓
app-page.run...dev.js gzip 136 kB 136 kB ✓
app-page.run..prod.js gzip 90.2 kB 90.2 kB ✓
app-route-ex...dev.js gzip 22 kB 22 kB ✓
app-route-ex..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route-tu..prod.js gzip 14.6 kB 14.6 kB ✓
app-route.ru...dev.js gzip 21.7 kB 21.7 kB ✓
app-route.ru..prod.js gzip 14.6 kB 14.6 kB ✓
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB ✓
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB ✓
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB ✓
pages-turbo...prod.js gzip 22.1 kB 22.1 kB ✓
pages.runtim...dev.js gzip 22.7 kB 22.7 kB ✓
pages.runtim..prod.js gzip 22.1 kB 22.1 kB ✓
server.runti..prod.js gzip 49.9 kB 49.9 kB ✓
Overall change 925 kB 925 kB ✓
Diff details
Diff for page-32918797421dc98a.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    1748, 631, 789, 7669, 8136, 8151, 3830, 6505, 6016, 7881, 6244, 1481, 4639,
+    666, 2701, 1172, 2031, 6215, 681, 2503, 7630, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-f611ebdad6afc558.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    3830, 631, 789, 7669, 8136, 8151, 1748, 6505, 6016, 7881, 6244, 1481, 4639,
+    666, 2701, 1172, 2031, 6215, 681, 2503, 7630, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-e3d46de160d41f00.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    6505, 631, 789, 7669, 8136, 8151, 1748, 3830, 6016, 7881, 6244, 1481, 4639,
+    666, 2701, 1172, 2031, 6215, 681, 2503, 7630, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-7697b633185b9e84.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    6016, 631, 789, 7669, 8136, 8151, 1748, 3830, 6505, 7881, 6244, 1481, 4639,
+    666, 2701, 1172, 2031, 6215, 681, 2503, 7630, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-7643b903eeca9746.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    7881, 631, 789, 7669, 8136, 8151, 1748, 3830, 6505, 6016, 6244, 1481, 4639,
+    666, 2701, 1172, 2031, 6215, 681, 2503, 7630, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-993d692634acbd75.js 
deleted
Diff for page-9a8bd5ff2ab12f50.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    2031, 631, 789, 7669, 8136, 8151, 1748, 3830, 6505, 6016, 7881, 6244, 1481,
+    4639, 666, 2701, 1172, 6215, 681, 2503, 7630, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-487464ff1f04ebf3.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    2503, 631, 789, 7669, 8136, 8151, 1748, 3830, 6505, 6016, 7881, 6244, 1481,
+    4639, 666, 2701, 1172, 2031, 6215, 681, 7630, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-9f1e2a9b903b6896.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    7630, 631, 789, 7669, 8136, 8151, 1748, 3830, 6505, 6016, 7881, 6244, 1481,
+    4639, 666, 2701, 1172, 2031, 6215, 681, 2503, 9195, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-87b5e8ec023f9038.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    9195, 631, 789, 7669, 8136, 8151, 1748, 3830, 6505, 6016, 7881, 6244, 1481,
+    4639, 666, 2701, 1172, 2031, 6215, 681, 2503, 7630, 7680, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-5c6bf6652e4d27a8.js 
@@ -0,0 +1,31 @@
+(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
+  [
+    7680, 631, 789, 7669, 8136, 8151, 1748, 3830, 6505, 6016, 7881, 6244, 1481,
+    4639, 666, 2701, 1172, 2031, 6215, 681, 2503, 7630, 9195, 5519, 3951, 596,
+  ],
+  {
+    /***/ 6201: /***/ function (
+      __unused_webpack_module,
+      __unused_webpack_exports,
+      __webpack_require__
+    ) {
+      Promise.resolve(/* import() eager */).then(
+        __webpack_require__.t.bind(__webpack_require__, 1363, 23)
+      );
+
+      /***/
+    },
+  },
+  /******/ function (__webpack_require__) {
+    // webpackRuntimeModules
+    /******/ var __webpack_exec__ = function (moduleId) {
+      return __webpack_require__((__webpack_require__.s = moduleId));
+    };
+    /******/ __webpack_require__.O(0, [1363, 5658, 5746, 1744], function () {
+      return __webpack_exec__(6201);
+    });
+    /******/ var __webpack_exports__ = __webpack_require__.O();
+    /******/ _N_E = __webpack_exports__;
+    /******/
+  },
+]);
Diff for page-726c5eb61ada5227.js 
deleted
Commit: a862ec1

@ijjk
Copy link
Member

ijjk commented Feb 13, 2024 •
edited

Tests Passed

@kwonoj kwonoj merged commit 39deaa5 into canary Feb 14, 2024
71 checks passed
@kwonoj kwonoj deleted the refactor-reexport branch February 14, 2024 00:53
@github-actions github-actions bot added the locked label Mar 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwonoj @ijjk @wbinnssmith