Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Turbopack writes font optimization manifest #62079

Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 15, 2024

What?

Even though we don't support the legacy font optimization (what came before next/font) the manifest is read during builds, so we have to write an empty version of it.

Closes NEXT-2498

@ijjk ijjk added Font (next/font) Related to Next.js Font Optimization. created-by: Next.js team PRs by the Next.js team type: next labels Feb 15, 2024
Copy link
Member Author

timneutkens commented Feb 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Feb 15, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
buildDuration 20.4s 20.1s N/A
buildDurationCached 7.8s 7.8s N/A
nodeModulesSize 196 MB 196 MB ⚠️ +14.4 kB
nextStartRea..uration (ms) 428ms 426ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
1068-HASH.js gzip 30.2 kB 30.2 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.1 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
edge-ssr.js gzip 94.4 kB 94.4 kB N/A
page.js gzip 151 kB 151 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 44.4 kB 44.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.72 kB 2.72 kB
Next Runtimes
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.5 kB 95.5 kB
app-page-tur..prod.js gzip 97.3 kB 97.3 kB
app-page-tur..prod.js gzip 91.7 kB 91.7 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 50 kB 50 kB
Overall change 925 kB 925 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-15-Ensure_Turbopack_writes_font_optimization_manifest Change
0.pack gzip 1.55 MB 1.55 MB ⚠️ +484 B
index.pack gzip 104 kB 104 kB ⚠️ +148 B
Overall change 1.65 MB 1.65 MB ⚠️ +632 B
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: c0d0518

@ijjk
Copy link
Member

ijjk commented Feb 15, 2024

Failing test suites

Commit: c0d0518

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts (PPR)

  • app dir - navigation > query string > should handle unicode search params
Expand output

● app dir - navigation › query string › should handle unicode search params

request.response: Target page, context or browser has been closed

  37 |         const browser = await next.browser('/search-params?name=名')
  38 |         async function requestHandler(req: Request) {
> 39 |           const res = await req.response()
     |                                 ^
  40 |           if (!res) return
  41 |
  42 |           requests.push({

  at response (e2e/app-dir/navigation/navigation.test.ts:39:33)
  at cb (lib/browsers/playwright.ts:234:51)
  at Page.forEach (lib/browsers/playwright.ts:234:35)

Read more about building and testing Next.js in contributing.md.

packages/next/src/build/index.ts Outdated Show resolved Hide resolved
packages/next/src/build/index.ts Show resolved Hide resolved
@timneutkens timneutkens enabled auto-merge (squash) February 15, 2024 10:51
@timneutkens timneutkens merged commit e1a2d13 into canary Feb 15, 2024
65 of 71 checks passed
@timneutkens timneutkens deleted the 02-15-Ensure_Turbopack_writes_font_optimization_manifest branch February 15, 2024 11:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team Font (next/font) Related to Next.js Font Optimization. locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants