-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev option to Turbopack createProject() #62083
Merged
timneutkens
merged 10 commits into
canary
from
02-15-Add_dev_option_to_Turbopack_createProject_
Feb 15, 2024
Merged
Add dev option to Turbopack createProject() #62083
timneutkens
merged 10 commits into
canary
from
02-15-Add_dev_option_to_Turbopack_createProject_
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
a team,
ztanner,
feedthejim and
wyattjoh
as code owners
February 15, 2024 10:21
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Next.js team
PRs by the Next.js team
type: next
labels
Feb 15, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on Graphite |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
buildDuration | 21.8s | 21.7s | N/A |
buildDurationCached | 9.4s | 7.5s | N/A |
nodeModulesSize | 196 MB | 196 MB | |
nextStartRea..uration (ms) | 416ms | 437ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
1068-HASH.js gzip | 30.2 kB | 30.2 kB | N/A |
3f784ff6-HASH.js gzip | 53.5 kB | 53.5 kB | N/A |
4944-HASH.js gzip | 5.04 kB | 5.03 kB | N/A |
8423.HASH.js gzip | 181 B | 181 B | ✓ |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 237 B | 241 B | N/A |
main-HASH.js gzip | 32.1 kB | 32.1 kB | N/A |
webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
Overall change | 47.1 kB | 47.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
_app-HASH.js gzip | 196 B | 196 B | ✓ |
_error-HASH.js gzip | 184 B | 183 B | N/A |
amp-HASH.js gzip | 503 B | 504 B | N/A |
css-HASH.js gzip | 323 B | 324 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.51 kB | N/A |
edge-ssr-HASH.js gzip | 258 B | 259 B | N/A |
head-HASH.js gzip | 353 B | 351 B | N/A |
hooks-HASH.js gzip | 370 B | 370 B | ✓ |
image-HASH.js gzip | 4.21 kB | 4.2 kB | N/A |
index-HASH.js gzip | 259 B | 259 B | ✓ |
link-HASH.js gzip | 2.68 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 313 B | 314 B | N/A |
script-HASH.js gzip | 386 B | 385 B | N/A |
withRouter-HASH.js gzip | 309 B | 311 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 931 B | 931 B | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
_buildManifest.js gzip | 485 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
index.html gzip | 528 B | 527 B | N/A |
link.html gzip | 541 B | 540 B | N/A |
withRouter.html gzip | 525 B | 522 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
edge-ssr.js gzip | 94.4 kB | 94.4 kB | N/A |
page.js gzip | 151 kB | 151 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 625 B | 627 B | N/A |
middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
middleware.js gzip | 44.4 kB | 44.4 kB | N/A |
edge-runtime..pack.js gzip | 1.94 kB | 1.94 kB | ✓ |
Overall change | 2.1 kB | 2.1 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 166 kB | 166 kB | ✓ |
app-page-exp..prod.js gzip | 95.5 kB | 95.5 kB | ✓ |
app-page-tur..prod.js gzip | 97.3 kB | 97.3 kB | ✓ |
app-page-tur..prod.js gzip | 91.7 kB | 91.7 kB | ✓ |
app-page.run...dev.js gzip | 136 kB | 136 kB | ✓ |
app-page.run..prod.js gzip | 90.3 kB | 90.3 kB | ✓ |
app-route-ex...dev.js gzip | 22 kB | 22 kB | ✓ |
app-route-ex..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route-tu..prod.js gzip | 14.6 kB | 14.6 kB | ✓ |
app-route.ru...dev.js gzip | 21.7 kB | 21.7 kB | ✓ |
app-route.ru..prod.js gzip | 14.6 kB | 14.6 kB | ✓ |
pages-api-tu..prod.js gzip | 9.43 kB | 9.43 kB | ✓ |
pages-api.ru...dev.js gzip | 9.7 kB | 9.7 kB | ✓ |
pages-api.ru..prod.js gzip | 9.43 kB | 9.43 kB | ✓ |
pages-turbo...prod.js gzip | 22 kB | 22 kB | ✓ |
pages.runtim...dev.js gzip | 22.7 kB | 22.7 kB | ✓ |
pages.runtim..prod.js gzip | 22 kB | 22 kB | ✓ |
server.runti..prod.js gzip | 50 kB | 50 kB | ✓ |
Overall change | 925 kB | 925 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 02-15-Add_dev_option_to_Turbopack_createProject_ | Change | |
---|---|---|---|
0.pack gzip | 1.55 MB | 1.55 MB | |
index.pack gzip | 104 kB | 104 kB | N/A |
Overall change | 1.55 MB | 1.55 MB |
Diff details
Diff for page.js
Diff too large to display
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
Diff for main-HASH.js
Diff too large to display
This comment was marked as spam.
This comment was marked as spam.
sokra
approved these changes
Feb 15, 2024
C'est bon
Le jeu. 15 févr. 2024, 10:55, Tobias Koppers ***@***.***> a
écrit :
… ***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#62083 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATQKX2MNACK7W7EFJY6JCSTYTXSQTAVCNFSM6AAAAABDJ7EV6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBSGQ2TMNBQGU>
.
You are receiving this because you commented.Message ID: <vercel/next.
***@***.***>
|
timneutkens
force-pushed
the
02-15-Add_dev_option_to_Turbopack_createProject_
branch
from
February 15, 2024 10:57
053fbbf
to
c809a63
Compare
Base automatically changed from
02-15-Ensure_Turbopack_writes_font_optimization_manifest
to
canary
February 15, 2024 11:11
timneutkens
deleted the
02-15-Add_dev_option_to_Turbopack_createProject_
branch
February 15, 2024 12:50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Next.js team
PRs by the Next.js team
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the
dev
option to switch between development and production output flags for Turbopack.Note: This only adds the option, the
false
value (production) doesn't work yet.Closes NEXT-2499