OpenTelemetry: trace API routes in page router #62120

dvoytenko · 2024-02-15T21:37:58Z

No description provided.

ijjk · 2024-02-15T21:44:33Z

Failing test suites

Commit: c61cc86

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts

app dir - navigation > navigation between pages and app > should not continously initiate a mpa navigation to the same URL when router state changes

Expand output

● app dir - navigation › navigation between pages and app › should not continously initiate a mpa navigation to the same URL when router state changes

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#link-to-slow-page')
  -   locator resolved to visible <a href="/slow-page" id="link-to-slow-page">To /slow-page</a>

  421 |     return this.chain(() => {
  422 |       return page
> 423 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  424 |         .then(async (el) => {
  425 |           // it seems selenium waits longer and tests rely on this behavior
  426 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:423:10)

Read more about building and testing Next.js in contributing.md.

ijjk · 2024-02-15T21:50:37Z

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
buildDuration	19.9s	20s	⚠️ +131ms
buildDurationCached	8.7s	7.2s	N/A
nodeModulesSize	196 MB	196 MB	⚠️ +41 kB
nextStartRea..uration (ms)	426ms	433ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
1068-HASH.js gzip	30.3 kB	30.3 kB	N/A
3f784ff6-HASH.js gzip	53.5 kB	53.5 kB	N/A
4944-HASH.js gzip	5.04 kB	5.03 kB	N/A
8423.HASH.js gzip	181 B	181 B	✓
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	242 B	N/A
main-HASH.js gzip	32.1 kB	32.1 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	47.1 kB	47.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
_app-HASH.js gzip	196 B	196 B	✓
_error-HASH.js gzip	184 B	183 B	N/A
amp-HASH.js gzip	503 B	504 B	N/A
css-HASH.js gzip	323 B	324 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.51 kB	N/A
edge-ssr-HASH.js gzip	258 B	259 B	N/A
head-HASH.js gzip	353 B	351 B	N/A
hooks-HASH.js gzip	370 B	370 B	✓
image-HASH.js gzip	4.21 kB	4.2 kB	N/A
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.68 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	313 B	314 B	N/A
script-HASH.js gzip	386 B	385 B	N/A
withRouter-HASH.js gzip	309 B	311 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	931 B	931 B	✓

Client Build Manifests

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
_buildManifest.js gzip	485 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
index.html gzip	528 B	528 B	✓
link.html gzip	541 B	541 B	✓
withRouter.html gzip	524 B	521 B	N/A
Overall change	1.07 kB	1.07 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
edge-ssr.js gzip	94.4 kB	94.5 kB	N/A
page.js gzip	151 kB	151 kB	N/A
Overall change	0 B	0 B	✓

Middleware size Overall increase ⚠️

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
middleware-b..fest.js gzip	625 B	625 B	✓
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	44.4 kB	44.6 kB	⚠️ +171 B
edge-runtime..pack.js gzip	1.94 kB	1.94 kB	✓
Overall change	47.1 kB	47.3 kB	⚠️ +171 B

Next Runtimes Overall increase ⚠️

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
app-page-exp...dev.js gzip	166 kB	166 kB	⚠️ +173 B
app-page-exp..prod.js gzip	95.6 kB	95.9 kB	⚠️ +278 B
app-page-tur..prod.js gzip	97.3 kB	97.6 kB	⚠️ +253 B
app-page-tur..prod.js gzip	91.8 kB	92 kB	⚠️ +254 B
app-page.run...dev.js gzip	136 kB	136 kB	⚠️ +236 B
app-page.run..prod.js gzip	90.3 kB	90.6 kB	⚠️ +250 B
app-route-ex...dev.js gzip	22 kB	22 kB	N/A
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	N/A
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	N/A
app-route-tu..prod.js gzip	14.6 kB	14.6 kB	N/A
app-route.ru...dev.js gzip	21.7 kB	21.7 kB	N/A
app-route.ru..prod.js gzip	14.6 kB	14.6 kB	N/A
pages-api-tu..prod.js gzip	9.43 kB	9.47 kB	N/A
pages-api.ru...dev.js gzip	9.7 kB	9.74 kB	N/A
pages-api.ru..prod.js gzip	9.43 kB	9.47 kB	N/A
pages-turbo...prod.js gzip	22 kB	22.1 kB	N/A
pages.runtim...dev.js gzip	22.7 kB	22.7 kB	N/A
pages.runtim..prod.js gzip	22 kB	22.1 kB	N/A
server.runti..prod.js gzip	50 kB	50.1 kB	N/A
Overall change	677 kB	679 kB	⚠️ +1.44 kB

build cache Overall increase ⚠️

	vercel/next.js canary	dvoytenko/next.js otel-pages-api-edge	Change
0.pack gzip	1.55 MB	1.55 MB	N/A
index.pack gzip	103 kB	104 kB	⚠️ +209 B
Overall change	103 kB	104 kB	⚠️ +209 B

Diff details

Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

failed to diff

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for pages-api-tu..time.prod.js

Diff too large to display

Diff for pages-api.runtime.dev.js

Diff too large to display

Diff for pages-api.ru..time.prod.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Diff for pages.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: c61cc86

ijjk

Changes look good, although seems we might need to update some tests

dvoytenko requested review from timneutkens, ijjk, shuding, huozhi, ztanner, feedthejim, a team and wyattjoh as code owners February 15, 2024 21:38

ijjk added area: tests type: next labels Feb 15, 2024

ijjk reviewed Feb 15, 2024

View reviewed changes

dvoytenko force-pushed the otel-pages-api-edge branch from a538eec to 16c8e50 Compare February 15, 2024 23:25

ijjk approved these changes Feb 16, 2024

View reviewed changes

dvoytenko added 3 commits February 15, 2024 17:29

OpenTelemetry: trace API routes in page router

24bbffc

ensure a recent otel version

0a2882e

fix source position in middleware

10f1d25

dvoytenko force-pushed the otel-pages-api-edge branch from 117404c to 10f1d25 Compare February 16, 2024 01:29

ijjk added 2 commits February 15, 2024 18:06

revert extra change

5f267bd

update test

c61cc86

ijjk enabled auto-merge (squash) February 16, 2024 03:36

ijjk merged commit b4db808 into vercel:canary Feb 16, 2024
65 checks passed

dvoytenko deleted the otel-pages-api-edge branch February 16, 2024 05:58

github-actions bot added the locked label Mar 1, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenTelemetry: trace API routes in page router #62120

OpenTelemetry: trace API routes in page router #62120

dvoytenko commented Feb 15, 2024

ijjk commented Feb 15, 2024 •

edited

ijjk commented Feb 15, 2024 •

edited

ijjk left a comment

OpenTelemetry: trace API routes in page router #62120

OpenTelemetry: trace API routes in page router #62120

Conversation

dvoytenko commented Feb 15, 2024

ijjk commented Feb 15, 2024 • edited

Failing test suites

ijjk commented Feb 15, 2024 • edited

Stats from current PR

ijjk left a comment

Choose a reason for hiding this comment

ijjk commented Feb 15, 2024 •

edited

ijjk commented Feb 15, 2024 •

edited