Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route/middleware/instrumentation use server assets instead of client assets #62134

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 16, 2024

What?

route/middleware/instrumentation use server assets
server assets use full url rewrite

Why?

How?

vercel/turbo#7750

Fixes PACK-2522

fixes PACK-2645

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Feb 16, 2024
@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
buildDuration 13.7s 14s ⚠️ +275ms
buildDurationCached 8.4s 6.1s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 439ms 430ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
2453-HASH.js gzip 30.8 kB 30.8 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 98.6 kB 98.6 kB
app-page-tur..prod.js gzip 93.1 kB 93.1 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.54 kB 9.54 kB
pages-api.ru...dev.js gzip 9.81 kB 9.81 kB
pages-api.ru..prod.js gzip 9.54 kB 9.54 kB
pages-turbo...prod.js gzip 22.4 kB 22.4 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 50.9 kB 50.9 kB
Overall change 945 kB 945 kB
build cache
vercel/next.js canary vercel/next.js sokra/route-chunking-and-url Change
0.pack gzip 1.57 MB 1.56 MB N/A
index.pack gzip 106 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: d9ebb61

@sokra sokra force-pushed the sokra/route-chunking-and-url branch from 206a357 to e7aa2c7 Compare March 12, 2024 21:37
@sokra sokra force-pushed the sokra/route-chunking-and-url branch from e7aa2c7 to 1a37316 Compare March 12, 2024 21:38
@sokra sokra marked this pull request as ready for review March 18, 2024 14:53
@sokra sokra marked this pull request as draft March 18, 2024 14:53
sokra added a commit to vercel/turbo that referenced this pull request Mar 19, 2024
### Description

The default for asset prefix is `"/"` and not `""`

### Testing Instructions

vercel/next.js#62134
@sokra sokra force-pushed the sokra/route-chunking-and-url branch from 4e4e639 to d9ebb61 Compare March 20, 2024 10:12
@sokra sokra marked this pull request as ready for review March 20, 2024 10:42
@timneutkens timneutkens merged commit 1c998d8 into canary Mar 20, 2024
76 checks passed
@timneutkens timneutkens deleted the sokra/route-chunking-and-url branch March 20, 2024 11:06
@github-actions github-actions bot added the locked label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants