Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fetch to propagate arbitrary init options #62168

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

dvoytenko
Copy link
Member

No description provided.

@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Failing test suites

Commit: d806fc4

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts

  • app dir - navigation > query string > should handle unicode search params
Expand output

● app dir - navigation › query string › should handle unicode search params

request.response: Target page, context or browser has been closed

  37 |         const browser = await next.browser('/search-params?name=名')
  38 |         async function requestHandler(req: Request) {
> 39 |           const res = await req.response()
     |                                 ^
  40 |           if (!res) return
  41 |
  42 |           requests.push({

  at response (e2e/app-dir/navigation/navigation.test.ts:39:33)
  at cb (lib/browsers/playwright.ts:234:51)
  at Page.forEach (lib/browsers/playwright.ts:234:35)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 16, 2024

Stats from current PR

Default Build
General
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
buildDuration 14.4s 14.3s N/A
buildDurationCached 7.9s 8s ⚠️ +169ms
nodeModulesSize 197 MB 197 MB N/A
nextStartRea..uration (ms) 435ms 440ms N/A
Client Bundles (main, webpack)
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
1068-HASH.js gzip 30.3 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
index.html gzip 526 B 528 B N/A
link.html gzip 540 B 540 B
withRouter.html gzip 524 B 522 B N/A
Overall change 540 B 540 B
Edge SSR bundle Size
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
edge-ssr.js gzip 2.29 kB 2.29 kB N/A
page.js gzip 2.98 kB 2.98 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 466 B 465 B N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.9 kB 95.9 kB
app-page-tur..prod.js gzip 97.6 kB 97.6 kB
app-page-tur..prod.js gzip 92 kB 92 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.6 kB 90.6 kB
app-route-ex...dev.js gzip 22 kB 22 kB N/A
app-route-ex..prod.js gzip 14.9 kB 14.9 kB N/A
app-route-tu..prod.js gzip 14.9 kB 14.9 kB N/A
app-route-tu..prod.js gzip 14.6 kB 14.7 kB N/A
app-route.ru...dev.js gzip 21.7 kB 21.7 kB N/A
app-route.ru..prod.js gzip 14.6 kB 14.7 kB N/A
pages-api-tu..prod.js gzip 9.47 kB 9.47 kB
pages-api.ru...dev.js gzip 9.74 kB 9.74 kB
pages-api.ru..prod.js gzip 9.47 kB 9.47 kB
pages-turbo...prod.js gzip 22.1 kB 22.1 kB
pages.runtim...dev.js gzip 22.8 kB 22.8 kB
pages.runtim..prod.js gzip 22.1 kB 22.1 kB
server.runti..prod.js gzip 50.2 kB 50.2 kB
Overall change 824 kB 824 kB
build cache
vercel/next.js canary dvoytenko/next.js fetch_preserve_init Change
0.pack gzip 1.49 MB 1.49 MB N/A
index.pack gzip 104 kB 104 kB N/A
Overall change 0 B 0 B
Diff details
Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: d806fc4

@ijjk ijjk enabled auto-merge (squash) February 20, 2024 18:30
@ijjk ijjk merged commit 6624723 into vercel:canary Feb 20, 2024
64 checks passed
@dvoytenko dvoytenko deleted the fetch_preserve_init branch February 20, 2024 18:31
@github-actions github-actions bot added the locked label Mar 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants