Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: generateSitemaps in production giving 404 #62212

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

abhinaypandey02
Copy link
Contributor

What?

generateSitemaps function returns a 404 for /sitemap/[id].xml in production

Why?

While finding the correct sitemap partition from the array, we check the param against the id. Which works in dev because id and param are both without trailing .xml. But it fails in production as param has a trailing .xml (/sitemap/[id] works in production because it falls back to dynamic loading and param and id are both without .xml)

How?

If we are in production environment, check the id with a trailing .xml because that's whats returned from generateStaticParams, an array of metadata_id with trailing .xml

Fixes #61969

@ijjk
Copy link
Member

ijjk commented Feb 28, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary abhinaypandey02/next.js abhinay Change
buildDuration 13.9s 14.3s ⚠️ +424ms
buildDurationCached 7.4s 7.8s ⚠️ +330ms
nodeModulesSize 197 MB 197 MB N/A
nextStartRea..uration (ms) 407ms 406ms N/A
Client Bundles (main, webpack)
vercel/next.js canary abhinaypandey02/next.js abhinay Change
2453-HASH.js gzip 30.5 kB 30.3 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.5 kB N/A
8299-HASH.js gzip 5.04 kB 5.03 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.1 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary abhinaypandey02/next.js abhinay Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary abhinaypandey02/next.js abhinay Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 505 B 504 B N/A
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 352 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.2 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.57 kB 1.57 kB
Client Build Manifests
vercel/next.js canary abhinaypandey02/next.js abhinay Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary abhinaypandey02/next.js abhinay Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary abhinaypandey02/next.js abhinay Change
edge-ssr.js gzip 95.1 kB 2.29 kB N/A
page.js gzip 3.06 kB 2.98 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary abhinaypandey02/next.js abhinay Change
middleware-b..fest.js gzip 624 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 465 B N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary abhinaypandey02/next.js abhinay Change
app-page-exp...dev.js gzip 171 kB 166 kB N/A
app-page-exp..prod.js gzip 96.7 kB 95.9 kB N/A
app-page-tur..prod.js gzip 98.5 kB 97.6 kB N/A
app-page-tur..prod.js gzip 92.9 kB 92 kB N/A
app-page.run...dev.js gzip 150 kB 136 kB N/A
app-page.run..prod.js gzip 91.4 kB 90.6 kB N/A
app-route-ex...dev.js gzip 21.3 kB 22 kB ⚠️ +757 B
app-route-ex..prod.js gzip 15 kB 14.9 kB N/A
app-route-tu..prod.js gzip 15 kB 14.9 kB N/A
app-route-tu..prod.js gzip 14.8 kB 14.6 kB N/A
app-route.ru...dev.js gzip 20.9 kB 21.7 kB ⚠️ +796 B
app-route.ru..prod.js gzip 14.8 kB 14.6 kB N/A
pages-api-tu..prod.js gzip 9.51 kB 9.47 kB N/A
pages-api.ru...dev.js gzip 9.79 kB 9.74 kB N/A
pages-api.ru..prod.js gzip 9.51 kB 9.47 kB N/A
pages-turbo...prod.js gzip 22.3 kB 22.1 kB N/A
pages.runtim...dev.js gzip 23 kB 22.7 kB N/A
pages.runtim..prod.js gzip 22.3 kB 22.1 kB N/A
server.runti..prod.js gzip 50.6 kB 50.1 kB N/A
Overall change 42.2 kB 43.8 kB ⚠️ +1.55 kB
build cache Overall increase ⚠️
vercel/next.js canary abhinaypandey02/next.js abhinay Change
0.pack gzip 1.56 MB 1.49 MB N/A
index.pack gzip 104 kB 104 kB ⚠️ +110 B
Overall change 104 kB 104 kB ⚠️ +110 B
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Diff for pages-api-tu..time.prod.js

Diff too large to display

Diff for pages-api.runtime.dev.js

Diff too large to display

Diff for pages-api.ru..time.prod.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Diff for pages.runtime.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: ca4b6b9

Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test, looks good!

@huozhi huozhi merged commit f38dc18 into vercel:canary Feb 28, 2024
63 checks passed
huozhi added a commit that referenced this pull request Mar 4, 2024
generateSitemaps function returns a 404 for /sitemap/[id].xml in
production

While finding the correct sitemap partition from the array, we check the
param against the id. Which works in dev because id and param are both
without trailing .xml. But it fails in production as param has a
trailing .xml (/sitemap/[id] works in production because it falls back
to dynamic loading and param and id are both without .xml)

If we are in production environment, check the id with a trailing .xml
because that's whats returned from generateStaticParams, an array of
__metadata_id__ with trailing .xml

Fixes #61969

---------

Co-authored-by: Jiachi Liu <inbox@huozhi.im>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
@abhinaypandey02 abhinaypandey02 deleted the abhinay branch March 14, 2024 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generateSitemaps is broken in production
3 participants