Update turbopack #62263
Merged
Update turbopack #62263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| buildDuration | 14.3s | 14.3s | N/A |
| buildDurationCached | 7.5s | 7.9s | |
| nodeModulesSize | 197 MB | 197 MB | ✓ |
| nextStartRea..uration (ms) | 402ms | 426ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| 1068-HASH.js gzip | 30.3 kB | 30.3 kB | N/A |
| 3f784ff6-HASH.js gzip | 53.5 kB | 53.5 kB | N/A |
| 4944-HASH.js gzip | 5.04 kB | 5.03 kB | N/A |
| 8423.HASH.js gzip | 181 B | 181 B | ✓ |
| framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
| main-app-HASH.js gzip | 241 B | 242 B | N/A |
| main-HASH.js gzip | 32.1 kB | 32.1 kB | N/A |
| webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
| Overall change | 47.1 kB | 47.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 196 B | 196 B | ✓ |
| _error-HASH.js gzip | 184 B | 183 B | N/A |
| amp-HASH.js gzip | 503 B | 504 B | N/A |
| css-HASH.js gzip | 323 B | 324 B | N/A |
| dynamic-HASH.js gzip | 2.5 kB | 2.51 kB | N/A |
| edge-ssr-HASH.js gzip | 258 B | 259 B | N/A |
| head-HASH.js gzip | 353 B | 351 B | N/A |
| hooks-HASH.js gzip | 370 B | 370 B | ✓ |
| image-HASH.js gzip | 4.21 kB | 4.2 kB | N/A |
| index-HASH.js gzip | 259 B | 259 B | ✓ |
| link-HASH.js gzip | 2.68 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 313 B | 314 B | N/A |
| script-HASH.js gzip | 386 B | 385 B | N/A |
| withRouter-HASH.js gzip | 309 B | 311 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 931 B | 931 B | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 485 B | 484 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| index.html gzip | 528 B | 526 B | N/A |
| link.html gzip | 540 B | 540 B | ✓ |
| withRouter.html gzip | 523 B | 522 B | N/A |
| Overall change | 540 B | 540 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 2.29 kB | 2.29 kB | N/A |
| page.js gzip | 2.98 kB | 2.98 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 624 B | 626 B | N/A |
| middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
| middleware.js gzip | 466 B | 466 B | ✓ |
| edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
| Overall change | 1.46 kB | 1.46 kB | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 166 kB | 166 kB | ✓ |
| app-page-exp..prod.js gzip | 95.9 kB | 95.9 kB | ✓ |
| app-page-tur..prod.js gzip | 97.6 kB | 97.6 kB | ✓ |
| app-page-tur..prod.js gzip | 92 kB | 92 kB | ✓ |
| app-page.run...dev.js gzip | 136 kB | 136 kB | ✓ |
| app-page.run..prod.js gzip | 90.6 kB | 90.6 kB | ✓ |
| app-route-ex...dev.js gzip | 22 kB | 22 kB | ✓ |
| app-route-ex..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| app-route-tu..prod.js gzip | 14.6 kB | 14.6 kB | ✓ |
| app-route.ru...dev.js gzip | 21.7 kB | 21.7 kB | ✓ |
| app-route.ru..prod.js gzip | 14.6 kB | 14.6 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.47 kB | 9.47 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.74 kB | 9.74 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.47 kB | 9.47 kB | ✓ |
| pages-turbo...prod.js gzip | 22.1 kB | 22.1 kB | ✓ |
| pages.runtim...dev.js gzip | 22.8 kB | 22.8 kB | ✓ |
| pages.runtim..prod.js gzip | 22.1 kB | 22.1 kB | ✓ |
| server.runti..prod.js gzip | 50.2 kB | 50.2 kB | ✓ |
| Overall change | 927 kB | 927 kB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js kdy1/update-turbopack | Change | |
|---|---|---|---|
| 0.pack gzip | 1.49 MB | 1.49 MB | N/A |
| index.pack gzip | 104 kB | 104 kB | |
| Overall change | 104 kB | 104 kB |
sokra
pushed a commit
to vercel/turbo
that referenced
this pull request
Feb 20, 2024
Reverts #7417 CI of next.js failed: vercel/next.js#62263 (comment) <details> <summary>CI failure</summary> ## Failing test suites <!--20914615487--> Commit: 3b35c10775c95136547b2f03248c9fafeaba9d01 `TURBOPACK=1 pnpm test test/integration/no-page-props/test/index.test.js` (turbopack) - Error no pageProps > dev mode > should navigate between pages correctly <details> <summary>Expand output</summary> ● Error no pageProps › dev mode › should navigate between pages correctly thrown: "Exceeded timeout of 60000 ms for a test. Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout." 44 | }) 45 | > 46 | it('should navigate between pages correctly', async () => { | ^ 47 | const browser = await webdriver(appPort, '/') 48 | 49 | await browser.eval('window.beforeNav = "hi"') at it (integration/no-page-props/test/index.test.js:46:3) at runTests (integration/no-page-props/test/index.test.js:90:5) at describe (integration/no-page-props/test/index.test.js:83:3) at Object.describe (integration/no-page-props/test/index.test.js:82:1) </details> Read more about building and testing Next.js in [contributing.md](https://github.com/vercel/next.js/blob/canary/contributing.md). `TURBOPACK=1 pnpm test test/integration/next-image-new/base-path/test/index.test.js` (turbopack) - Image Component basePath Tests > dev mode > should update the image on src change - Image Component basePath Tests > dev mode > should show invalid src error - Image Component basePath Tests > dev mode > should correctly ignore prose styles <details> <summary>Expand output</summary> ● Image Component basePath Tests › dev mode › should update the image on src change TIMED OUT: /test\.png/ http://localhost:43027/docs/_next/image?url=%2Ftest.jpg&w=828&q=75 undefined 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (integration/next-image-new/base-path/test/index.test.js:97:7) ● Image Component basePath Tests › dev mode › should show invalid src error expect(received).toBe(expected) // Object.is equality Expected: true Received: false 143 | const browser = await webdriver(appPort, '/docs/invalid-src') 144 | > 145 | expect(await hasRedbox(browser)).toBe(true) | ^ 146 | expect(await getRedboxHeader(browser)).toContain( 147 | 'Invalid src prop (https://google.com/test.png) on `next/image`, hostname "google.com" is not configured under images in your `next.config.js`' 148 | ) at Object.toBe (integration/next-image-new/base-path/test/index.test.js:145:40) ● Image Component basePath Tests › dev mode › should correctly ignore prose styles TIMED OUT: /result-correct/ undefined Error: Image not ready 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (integration/next-image-new/base-path/test/index.test.js:172:7) </details> Read more about building and testing Next.js in [contributing.md](https://github.com/vercel/next.js/blob/canary/contributing.md). `pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts` - app dir - navigation > query string > should handle unicode search params <details> <summary>Expand output</summary> ● app dir - navigation › query string › should handle unicode search params request.response: Target page, context or browser has been closed 37 | const browser = await next.browser('/search-params?name=名') 38 | async function requestHandler(req: Request) { > 39 | const res = await req.response() | ^ 40 | if (!res) return 41 | 42 | requests.push({ at response (e2e/app-dir/navigation/navigation.test.ts:39:33) at cb (lib/browsers/playwright.ts:234:51) at Page.forEach (lib/browsers/playwright.ts:234:35) </details> Read more about building and testing Next.js in [contributing.md](https://github.com/vercel/next.js/blob/canary/contributing.md). `TURBOPACK=1 pnpm test test/integration/next-image-legacy/base-path/test/index.test.ts` (turbopack) - Image Component basePath Tests > dev mode > should work with layout-intrinsic so resizing window maintains image aspect ratio - Image Component basePath Tests > dev mode > should work with layout-responsive so resizing window maintains image aspect ratio - Image Component basePath Tests > dev mode > should work with layout-fill to fill the parent and stretch with viewport - Image Component basePath Tests > dev mode > should work with sizes and automatically use layout-responsive - Image Component basePath Tests > dev mode > should show missing src error - Image Component basePath Tests > dev mode > should show invalid src error - Image Component basePath Tests > dev mode > should show invalid src error when protocol-relative <details> <summary>Expand output</summary> ● Image Component basePath Tests › dev mode › should work with layout-intrinsic so resizing window maintains image aspect ratio TIMED OUT: success undefined Error: expect(received).toBe(expected) // Object.is equality Expected: "/docs/_next/image?url=%2Fdocs%2Fwide.png&w=3840&q=75" Received: ":image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (integration/next-image-legacy/base-path/test/index.test.ts:165:7) ● Image Component basePath Tests › dev mode › should work with layout-responsive so resizing window maintains image aspect ratio TIMED OUT: success undefined Error: expect(received).toBe(expected) // Object.is equality Expected: "/docs/_next/image?url=%2Fdocs%2Fwide.png&w=3840&q=75" Received: ":image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (integration/next-image-legacy/base-path/test/index.test.ts:206:7) ● Image Component basePath Tests › dev mode › should work with layout-fill to fill the parent and stretch with viewport TIMED OUT: success undefined Error: expect(received).toBe(expected) // Object.is equality Expected: "/docs/_next/image?url=%2Fdocs%2Fwide.png&w=3840&q=75" Received: ":image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (integration/next-image-legacy/base-path/test/index.test.ts:288:7) ● Image Component basePath Tests › dev mode › should work with sizes and automatically use layout-responsive TIMED OUT: success undefined Error: expect(received).toBe(expected) // Object.is equality Expected: "/docs/_next/image?url=%2Fdocs%2Fwide.png&w=3840&q=75" Received: ":image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7" 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (integration/next-image-legacy/base-path/test/index.test.ts:339:7) ● Image Component basePath Tests › dev mode › should show missing src error TIMED OUT: /Image is missing required "src" property/gm undefined 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (integration/next-image-legacy/base-path/test/index.test.ts:380:7) ● Image Component basePath Tests › dev mode › should show invalid src error expect(received).toBe(expected) // Object.is equality Expected: true Received: false 386 | const browser = await webdriver(appPort, '/docs/invalid-src') 387 | > 388 | expect(await hasRedbox(browser)).toBe(true) | ^ 389 | expect(await getRedboxHeader(browser)).toContain( 390 | 'Invalid src prop (https://google.com/test.png) on `next/image`, hostname "google.com" is not configured under images in your `next.config.js`' 391 | ) at Object.toBe (integration/next-image-legacy/base-path/test/index.test.ts:388:40) ● Image Component basePath Tests › dev mode › should show invalid src error when protocol-relative expect(received).toBe(expected) // Object.is equality Expected: true Received: false 398 | ) 399 | > 400 | expect(await hasRedbox(browser)).toBe(true) | ^ 401 | expect(await getRedboxHeader(browser)).toContain( 402 | 'Failed to parse src "//assets.example.com/img.jpg" on `next/image`, protocol-relative URL (//) must be changed to an absolute URL (http:// or https://)' 403 | ) at Object.toBe (integration/next-image-legacy/base-path/test/index.test.ts:400:40) </details> Read more about building and testing Next.js in [contributing.md](https://github.com/vercel/next.js/blob/canary/contributing.md). `TURBOPACK=1 pnpm test-dev test/development/basic/next-dynamic.test.ts` (turbopack) - basic next/dynamic usage, basePath: "" with "document.getInitialProps" compiler > document.getInitialProps > Dynamic import > custom loading > should render the component on client side - basic next/dynamic usage, basePath: "" with "swc" compiler > swc > Dynamic import > custom loading > should render the component on client side - basic next/dynamic usage, basePath: "/docs" with "swc" compiler > swc > Dynamic import > custom loading > should render the component on client side <details> <summary>Expand output</summary> ● basic next/dynamic usage, basePath: "" with "swc" compiler › swc › Dynamic import › custom loading › should render the component on client side TIMED OUT: /Hello World 1/ LOADING{"props":{"pageProps":{}},"page":"/dynamic/no-ssr-custom-loading","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]} undefined 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (development/basic/next-dynamic.test.ts:302:17) ● basic next/dynamic usage, basePath: "/docs" with "swc" compiler › swc › Dynamic import › custom loading › should render the component on client side TIMED OUT: /Hello World 1/ LOADING{"props":{"pageProps":{}},"page":"/dynamic/no-ssr-custom-loading","query":{},"buildId":"development","assetPrefix":"/docs","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]} undefined 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (development/basic/next-dynamic.test.ts:302:17) ● basic next/dynamic usage, basePath: "" with "document.getInitialProps" compiler › document.getInitialProps › Dynamic import › custom loading › should render the component on client side TIMED OUT: /Hello World 1/ LOADING{"props":{"pageProps":{}},"page":"/dynamic/no-ssr-custom-loading","query":{},"buildId":"development","nextExport":true,"autoExport":true,"isFallback":false,"scriptLoader":[]} undefined 636 | 637 | if (hardError) { > 638 | throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr) | ^ 639 | } 640 | return false 641 | } at check (lib/next-test-utils.ts:638:11) at Object.<anonymous> (development/basic/next-dynamic.test.ts:302:17) </details> Read more about building and testing Next.js in [contributing.md](https://github.com/vercel/next.js/blob/canary/contributing.md). </details> Closes PACK-2541
kdy1
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
sokra
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
swc_coretov0.90.10turbo#7416Why?
To keep in sync
How?
Closes PACK-2540