Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbopack: limit build concurrency, show progress bar #62319

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 21, 2024

What?

Run 10 concurrent Turbopack compilation jobs instead of all of them
show a progress spinner

Why?

  • In future this allows to reclaim memory for finished jobs
  • It looks nicer in tracing

Closes PACK-2561

@ijjk
Copy link
Member

ijjk commented Feb 21, 2024

Failing test suites

Commit: 742e956

TURBOPACK=1 pnpm test test/integration/cli/test/index.test.js (turbopack)

  • CLI Usage > dev > NODE_OPTIONS='--inspect'
Expand output

● CLI Usage › dev › NODE_OPTIONS='--inspect'

TIMED OUT: /Debugger listening on/

Starting inspector on 127.0.0.1:9229 failed: address already in use
Starting inspector on 127.0.0.1:9230 failed: address already in use


undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (integration/cli/test/index.test.js:549:9)

Read more about building and testing Next.js in contributing.md.

pnpm test test/integration/app-dir-export/test/dynamicapiroute-prod.test.ts

  • app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicApiRoute undefined
  • app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicApiRoute 'error'
  • app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicApiRoute 'force-static'
  • app dir - with output export - dynamic api route prod > production mode > should work in prod with dynamicApiRoute 'force-dynamic'
Expand output

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicApiRoute undefined

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  12 |           'export const dynamic = "force-dynamic" on page "/api/json" cannot be used with "output: export".',
  13 |       },
> 14 |     ])(
     |      ^
  15 |       'should work in prod with dynamicApiRoute $dynamicApiRoute',
  16 |       async ({ dynamicApiRoute, expectedErrMsg }) => {
  17 |         await runTests({ isDev: false, dynamicApiRoute, expectedErrMsg })

  at ../node_modules/.pnpm/jest-each@29.7.0/node_modules/jest-each/build/bind.js:47:15
      at Array.forEach (<anonymous>)
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:14:6
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:4:52
  at Object.describe (integration/app-dir-export/test/dynamicapiroute-prod.test.ts:3:1)

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicApiRoute 'error'

Failed to replace content.

Pattern: const dynamic = 'force-static'

Content: export const dynamic = undefined

export async function GET() {
  return Response.json({ answer: 42 })
}

  669 |     } else if (typeof pattern === 'string') {
  670 |       if (!currentContent.includes(pattern)) {
> 671 |         throw new Error(
      |               ^
  672 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  673 |         )
  674 |       }

  at File.replace (lib/next-test-utils.ts:671:15)
  at replace (integration/app-dir-export/test/utils.ts:118:13)
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:17:23

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicApiRoute 'force-static'

Failed to replace content.

Pattern: const dynamic = 'force-static'

Content: export const dynamic = undefined

export async function GET() {
  return Response.json({ answer: 42 })
}

  669 |     } else if (typeof pattern === 'string') {
  670 |       if (!currentContent.includes(pattern)) {
> 671 |         throw new Error(
      |               ^
  672 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  673 |         )
  674 |       }

  at File.replace (lib/next-test-utils.ts:671:15)
  at replace (integration/app-dir-export/test/utils.ts:118:13)
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:17:23

● app dir - with output export - dynamic api route prod › production mode › should work in prod with dynamicApiRoute 'force-dynamic'

Failed to replace content.

Pattern: const dynamic = 'force-static'

Content: export const dynamic = undefined

export async function GET() {
  return Response.json({ answer: 42 })
}

  669 |     } else if (typeof pattern === 'string') {
  670 |       if (!currentContent.includes(pattern)) {
> 671 |         throw new Error(
      |               ^
  672 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  673 |         )
  674 |       }

  at File.replace (lib/next-test-utils.ts:671:15)
  at replace (integration/app-dir-export/test/utils.ts:118:13)
  at integration/app-dir-export/test/dynamicapiroute-prod.test.ts:17:23

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 21, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
buildDuration 20.3s 19.9s N/A
buildDurationCached 7.8s 7.8s N/A
nodeModulesSize 196 MB 196 MB ⚠️ +10.2 kB
nextStartRea..uration (ms) 430ms 437ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
1068-HASH.js gzip 30.3 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
index.html gzip 529 B 528 B N/A
link.html gzip 540 B 541 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
edge-ssr.js gzip 94.8 kB 94.8 kB N/A
page.js gzip 152 kB 152 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
middleware-b..fest.js gzip 627 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 44.9 kB 44.9 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 2.1 kB 2.1 kB
Next Runtimes
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 96.2 kB 96.2 kB
app-page-tur..prod.js gzip 97.9 kB 97.9 kB
app-page-tur..prod.js gzip 92.4 kB 92.4 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.9 kB 90.9 kB
app-route-ex...dev.js gzip 22.1 kB 22.1 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.7 kB 14.7 kB
app-route.ru...dev.js gzip 21.8 kB 21.8 kB
app-route.ru..prod.js gzip 14.7 kB 14.7 kB
pages-api-tu..prod.js gzip 9.49 kB 9.49 kB
pages-api.ru...dev.js gzip 9.76 kB 9.76 kB
pages-api.ru..prod.js gzip 9.48 kB 9.48 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.3 kB 50.3 kB
Overall change 930 kB 930 kB
build cache
vercel/next.js canary vercel/next.js sokra/build-parallelism Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 104 kB 104 kB N/A
Overall change 0 B 0 B
Commit: 742e956

@sokra sokra requested a review from wyattjoh as a code owner February 21, 2024 16:04
@sokra sokra changed the title Turbopack: only run 10 jobs concurrently Turbopack: limit build concurrency, show progress bar Feb 21, 2024
@sokra sokra enabled auto-merge (squash) February 21, 2024 16:42
@sokra sokra merged commit 46521db into canary Feb 21, 2024
70 checks passed
@sokra sokra deleted the sokra/build-parallelism branch February 21, 2024 20:55
@github-actions github-actions bot added the locked label Mar 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants