feat(error-overlay): hide <unknown>/stringify methods in <anonymous> file from stack

[balazsorban44]

What?

Clean up the error overlay:

Before:

After:

I also simplified the current code as it was likely using useMemo a bit eagerly.

Why?

This is an unactionable line by the user, no value in showing it in the overlay.

How?

Filter out the frame before rendering it in the overlay.

This answers this question too, since the module grouping is local. Now that <anonymous> is filtered out, the two Next.js groups are now merged into one, further cleaning up the stack.

Closes NEXT-2505

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
buildDuration	20.1s	19.9s	N/A
buildDurationCached	7.8s	7.8s	N/A
nodeModulesSize	196 MB	196 MB	N/A
nextStartRea..uration (ms)	422ms	405ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
1068-HASH.js gzip	30.3 kB	30.3 kB	N/A
3f784ff6-HASH.js gzip	53.5 kB	53.5 kB	N/A
4944-HASH.js gzip	5.04 kB	5.03 kB	N/A
8423.HASH.js gzip	181 B	181 B	✓
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	241 B	✓
main-HASH.js gzip	32.2 kB	32.1 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	47.3 kB	47.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
_app-HASH.js gzip	196 B	196 B	✓
_error-HASH.js gzip	184 B	183 B	N/A
amp-HASH.js gzip	503 B	504 B	N/A
css-HASH.js gzip	323 B	324 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.51 kB	N/A
edge-ssr-HASH.js gzip	258 B	259 B	N/A
head-HASH.js gzip	353 B	351 B	N/A
hooks-HASH.js gzip	370 B	370 B	✓
image-HASH.js gzip	4.21 kB	4.2 kB	N/A
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.68 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	313 B	314 B	N/A
script-HASH.js gzip	386 B	385 B	N/A
withRouter-HASH.js gzip	309 B	311 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	931 B	931 B	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
_buildManifest.js gzip	485 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
index.html gzip	529 B	528 B	N/A
link.html gzip	540 B	541 B	N/A
withRouter.html gzip	524 B	523 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
edge-ssr.js gzip	94.8 kB	94.8 kB	N/A
page.js gzip	152 kB	152 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
middleware-b..fest.js gzip	626 B	625 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	44.9 kB	44.9 kB	N/A
edge-runtime..pack.js gzip	1.94 kB	1.94 kB	✓
Overall change	2.1 kB	2.1 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
app-page-exp...dev.js gzip	167 kB	167 kB	✓
app-page-exp..prod.js gzip	96.2 kB	96.2 kB	✓
app-page-tur..prod.js gzip	97.9 kB	97.9 kB	✓
app-page-tur..prod.js gzip	92.4 kB	92.4 kB	✓
app-page.run...dev.js gzip	136 kB	136 kB	✓
app-page.run..prod.js gzip	90.9 kB	90.9 kB	✓
app-route-ex...dev.js gzip	22.1 kB	22.1 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.7 kB	14.7 kB	✓
app-route.ru...dev.js gzip	21.8 kB	21.8 kB	✓
app-route.ru..prod.js gzip	14.7 kB	14.7 kB	✓
pages-api-tu..prod.js gzip	9.49 kB	9.49 kB	✓
pages-api.ru...dev.js gzip	9.76 kB	9.76 kB	✓
pages-api.ru..prod.js gzip	9.48 kB	9.48 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	23 kB	23 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.3 kB	50.3 kB	✓
Overall change	930 kB	930 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js feat/hide-anonymous	Change
0.pack gzip	1.55 MB	1.55 MB	⚠️ +1.1 kB
index.pack gzip	104 kB	104 kB	⚠️ +153 B
Overall change	1.65 MB	1.66 MB	⚠️ +1.25 kB

Commit: f22e45b

[ijjk]

Failing test suites

Commit: f22e45b

pnpm test-dev test/e2e/app-dir/metadata/metadata.test.ts (PPR)

• app dir - metadata > react cache > should have same title and page value when navigating

Expand output

● app dir - metadata › react cache › should have same title and page value when navigating

expect(received).toBe(expected) // Object.is equality

Expected: "0.4247178291734226"
Received: "0.0842797168970213"

  973 |         const obj = JSON.parse(title)
  974 |         // Check `cache()`
> 975 |         expect(obj.val.toString()).toBe(value)
      |                                    ^
  976 |         // Check `fetch()`
  977 |         // TODO-APP: Investigate why fetch deduping doesn't apply but cache() does.
  978 |         if (!isNextDev) {

  at Object.toBe (e2e/app-dir/metadata/metadata.test.ts:975:36)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts (PPR)

• app dir - navigation > query string > should handle unicode search params

Expand output

● app dir - navigation › query string › should handle unicode search params

request.response: Target page, context or browser has been closed

  37 |         const browser = await next.browser('/search-params?name=名')
  38 |         async function requestHandler(req: Request) {
> 39 |           const res = await req.response()
     |                                 ^
  40 |           if (!res) return
  41 |
  42 |           requests.push({

  at response (e2e/app-dir/navigation/navigation.test.ts:39:33)
  at cb (lib/browsers/playwright.ts:234:51)
  at Page.forEach (lib/browsers/playwright.ts:234:35)

Read more about building and testing Next.js in contributing.md.

[balazsorban44]

Addresses #62206 (comment)