Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade vendored react #62326

Merged
merged 11 commits into from
Feb 23, 2024
Merged

Upgrade vendored react #62326

merged 11 commits into from
Feb 23, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 21, 2024 •
edited

React upstream changes

Closes NEXT-2542

Disable ppr test for strict mode for now, @acdlite will check it and we'll sync again

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 21, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Feb 21, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/react-dom@0.0.0-experimental-a515d753b-20240220 environment +3 17.9 MB react-bot
npm/react-dom@18.3.0-canary-a515d753b-20240220 environment +3 14.4 MB react-bot
npm/react-server-dom-turbopack@0.0.0-experimental-a515d753b-20240220 Transitive: environment +7 8.06 MB react-bot
npm/react-server-dom-turbopack@18.3.0-canary-a515d753b-20240220 Transitive: environment +7 7.85 MB react-bot
npm/react-server-dom-webpack@0.0.0-experimental-a515d753b-20240220 Transitive: environment, eval, filesystem, network, shell, unsafe +86 27.4 MB react-bot
npm/react-server-dom-webpack@18.3.0-canary-a515d753b-20240220 Transitive: environment, eval, filesystem, network, shell, unsafe +86 27.2 MB react-bot
npm/react@0.0.0-experimental-a515d753b-20240220 environment +1 665 kB react-bot
npm/react@18.3.0-canary-a515d753b-20240220 environment +2 650 kB react-bot
npm/scheduler@0.0.0-experimental-a515d753b-20240220 environment +1 220 kB react-bot
npm/scheduler@0.24.0-canary-a515d753b-20240220 environment +2 235 kB react-bot

🚮 Removed packages: npm/react-dom@0.0.0-experimental-ba5e6a832-20240208, npm/react-dom@18.3.0-canary-ba5e6a832-20240208, npm/react-server-dom-turbopack@0.0.0-experimental-ba5e6a832-20240208, npm/react-server-dom-turbopack@18.3.0-canary-ba5e6a832-20240208, npm/react-server-dom-webpack@0.0.0-experimental-ba5e6a832-20240208, npm/react-server-dom-webpack@18.3.0-canary-ba5e6a832-20240208, npm/react@0.0.0-experimental-ba5e6a832-20240208, npm/react@18.3.0-canary-ba5e6a832-20240208, npm/scheduler@0.0.0-experimental-ba5e6a832-20240208, npm/scheduler@0.24.0-canary-ba5e6a832-20240208

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Feb 21, 2024 •
edited

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 21, 2024 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
buildDuration 13.8s 13.9s N/A
buildDurationCached 7.9s 6.4s N/A
nodeModulesSize 196 MB 197 MB ⚠️ +743 kB
nextStartRea..uration (ms) 406ms 410ms N/A
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
1068-HASH.js gzip 30.3 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.7 kB ⚠️ +127 B
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B ✓
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 241 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB ✓
Overall change 101 kB 101 kB ⚠️ +127 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
_app-HASH.js gzip 196 B 196 B ✓
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B ✓
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 931 B 931 B ✓
Client Build Manifests
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
index.html gzip 528 B 527 B N/A
link.html gzip 540 B 540 B ✓
withRouter.html gzip 523 B 522 B N/A
Overall change 540 B 540 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
edge-ssr.js gzip 94.9 kB 94.9 kB N/A
page.js gzip 3.06 kB 3.05 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.4 kB 25.4 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
app-page-exp...dev.js gzip 167 kB 170 kB ⚠️ +2.88 kB
app-page-exp..prod.js gzip 96.3 kB 96.5 kB ⚠️ +265 B
app-page-tur..prod.js gzip 98 kB 98.3 kB ⚠️ +317 B
app-page-tur..prod.js gzip 92.4 kB 92.8 kB ⚠️ +392 B
app-page.run...dev.js gzip 136 kB 151 kB ⚠️ +14.8 kB
app-page.run..prod.js gzip 91 kB 91.3 kB ⚠️ +336 B
app-route-ex...dev.js gzip 22.1 kB 22 kB N/A
app-route-ex..prod.js gzip 15 kB 15 kB N/A
app-route-tu..prod.js gzip 15 kB 15 kB N/A
app-route-tu..prod.js gzip 14.7 kB 14.7 kB N/A
app-route.ru...dev.js gzip 21.8 kB 21.7 kB N/A
app-route.ru..prod.js gzip 14.7 kB 14.7 kB N/A
pages-api-tu..prod.js gzip 9.5 kB 9.5 kB ✓
pages-api.ru...dev.js gzip 9.78 kB 9.78 kB ✓
pages-api.ru..prod.js gzip 9.5 kB 9.5 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 23 kB 23 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.5 kB 50.5 kB ✓
Overall change 828 kB 847 kB ⚠️ +19 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js huozhi/upgrade-react Change
0.pack gzip 1.55 MB 1.55 MB N/A
index.pack gzip 105 kB 105 kB ⚠️ +252 B
Overall change 105 kB 105 kB ⚠️ +252 B
Diff details
Diff for 1068-HASH.js

Diff too large to display

Diff for 3f784ff6-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js 
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 4059eb0

@huozhi huozhi marked this pull request as ready for review February 23, 2024 10:50
@huozhi huozhi marked this pull request as draft February 23, 2024 11:01
@huozhi huozhi marked this pull request as ready for review February 23, 2024 11:10
@huozhi huozhi enabled auto-merge (squash) February 23, 2024 11:18
@huozhi huozhi changed the title Upgrade react Upgrade vendored react Feb 23, 2024
@huozhi huozhi disabled auto-merge February 23, 2024 11:36
@huozhi huozhi merged commit e5d604f into canary Feb 23, 2024
67 of 71 checks passed
@huozhi huozhi deleted the huozhi/upgrade-react branch February 23, 2024 11:46
@github-actions github-actions bot added the locked label Mar 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huozhi @ijjk @shuding