Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass prependData and additionalData to sass-loader for Turbopack #62397

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 22, 2024

What?

Ensures that prependData and additionalData are passed as loader options instead of as part of sassOptions, mirrors webpack behavior.

Covers two cases that currently fail in #62321.

Closes NEXT-2571

@timneutkens timneutkens requested review from ijjk, shuding, huozhi and a team as code owners February 22, 2024 13:36
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team type: next labels Feb 22, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Feb 22, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
buildDuration 14.3s 14.3s N/A
buildDurationCached 7.9s 6.5s N/A
nodeModulesSize 196 MB 196 MB
nextStartRea..uration (ms) 406ms 407ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
1068-HASH.js gzip 30.3 kB 30.3 kB N/A
3f784ff6-HASH.js gzip 53.5 kB 53.5 kB N/A
4944-HASH.js gzip 5.04 kB 5.03 kB N/A
8423.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 32.2 kB 32.1 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 47.1 kB 47.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
_app-HASH.js gzip 196 B 196 B
_error-HASH.js gzip 184 B 183 B N/A
amp-HASH.js gzip 503 B 504 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 2.5 kB 2.51 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 353 B 351 B N/A
hooks-HASH.js gzip 370 B 370 B
image-HASH.js gzip 4.21 kB 4.2 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.68 kB 2.67 kB N/A
routerDirect..HASH.js gzip 313 B 314 B N/A
script-HASH.js gzip 386 B 385 B N/A
withRouter-HASH.js gzip 309 B 311 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 931 B 931 B
Client Build Manifests
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
_buildManifest.js gzip 485 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
index.html gzip 528 B 528 B
link.html gzip 539 B 540 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 528 B 528 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
edge-ssr.js gzip 2.3 kB 2.3 kB
page.js gzip 2.99 kB 2.99 kB N/A
Overall change 2.3 kB 2.3 kB
Middleware size
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 465 B 464 B N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 96.2 kB 96.2 kB
app-page-tur..prod.js gzip 97.9 kB 97.9 kB
app-page-tur..prod.js gzip 92.4 kB 92.4 kB
app-page.run...dev.js gzip 136 kB 136 kB
app-page.run..prod.js gzip 90.9 kB 90.9 kB
app-route-ex...dev.js gzip 22.1 kB 22.1 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.7 kB 14.7 kB
app-route.ru...dev.js gzip 21.8 kB 21.8 kB
app-route.ru..prod.js gzip 14.7 kB 14.7 kB
pages-api-tu..prod.js gzip 9.49 kB 9.49 kB
pages-api.ru...dev.js gzip 9.76 kB 9.76 kB
pages-api.ru..prod.js gzip 9.48 kB 9.48 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.4 kB 50.4 kB
Overall change 930 kB 930 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack Change
0.pack gzip 1.49 MB 1.49 MB N/A
index.pack gzip 104 kB 104 kB ⚠️ +341 B
Overall change 104 kB 104 kB ⚠️ +341 B
Commit: 38f4673

@timneutkens timneutkens merged commit dae8756 into canary Feb 22, 2024
70 checks passed
@timneutkens timneutkens deleted the 02-22-Correctly_pass_prependData_and_additionalData_to_sass-loader_for_Turbopack branch February 22, 2024 17:42
@github-actions github-actions bot added the locked label Mar 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants