chore(cli): add clarifying comment

[samcx]

Changes

• Add clarifying comment around why we're process.exit(1) at the end of runLintCheck
• Related → fix(next-lint): fix next lint not throwing exit 1 on error #62378
• Fixes → next lint should fail with code !=0 when eslint is not installed #31605

Closes NEXT-2576

[ijjk]

Failing test suites

Commit: 6dd9edd

TURBOPACK=1 pnpm test test/integration/cli/test/index.test.js (turbopack)

• CLI Usage > dev > NODE_OPTIONS='--inspect'

Expand output

● CLI Usage › dev › NODE_OPTIONS='--inspect'

TIMED OUT: /Debugger listening on/

Starting inspector on 127.0.0.1:9229 failed: address already in use
Starting inspector on 127.0.0.1:9230 failed: address already in use


undefined

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (integration/cli/test/index.test.js:549:9)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/app-dir/navigation/navigation.test.ts (PPR)

• app dir - navigation > navigation between pages and app > should not continously initiate a mpa navigation to the same URL when router state changes

Expand output

● app dir - navigation › navigation between pages and app › should not continously initiate a mpa navigation to the same URL when router state changes

page.waitForSelector: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('#link-to-slow-page')
  -   locator resolved to visible <a href="/slow-page" id="link-to-slow-page">To /slow-page</a>

  421 |     return this.chain(() => {
  422 |       return page
> 423 |         .waitForSelector(selector, { timeout, state: 'attached' })
      |          ^
  424 |         .then(async (el) => {
  425 |           // it seems selenium waits longer and tests rely on this behavior
  426 |           // so we wait for the load event fire before returning

  at waitForSelector (lib/browsers/playwright.ts:423:10)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
buildDuration	14.4s	14.4s	N/A
buildDurationCached	7.6s	6.6s	N/A
nodeModulesSize	196 MB	196 MB	⚠️ +314 B
nextStartRea..uration (ms)	430ms	406ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
1068-HASH.js gzip	30.3 kB	30.3 kB	N/A
3f784ff6-HASH.js gzip	53.5 kB	53.5 kB	N/A
4944-HASH.js gzip	5.04 kB	5.03 kB	N/A
8423.HASH.js gzip	181 B	181 B	✓
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	243 B	242 B	N/A
main-HASH.js gzip	32.2 kB	32.1 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	47.1 kB	47.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
_app-HASH.js gzip	196 B	196 B	✓
_error-HASH.js gzip	184 B	183 B	N/A
amp-HASH.js gzip	503 B	504 B	N/A
css-HASH.js gzip	323 B	324 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.51 kB	N/A
edge-ssr-HASH.js gzip	258 B	259 B	N/A
head-HASH.js gzip	353 B	351 B	N/A
hooks-HASH.js gzip	370 B	370 B	✓
image-HASH.js gzip	4.21 kB	4.2 kB	N/A
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.68 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	313 B	314 B	N/A
script-HASH.js gzip	386 B	385 B	N/A
withRouter-HASH.js gzip	309 B	311 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	931 B	931 B	✓

Client Build Manifests

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
_buildManifest.js gzip	485 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
index.html gzip	528 B	528 B	✓
link.html gzip	539 B	540 B	N/A
withRouter.html gzip	523 B	522 B	N/A
Overall change	528 B	528 B	✓

Edge SSR bundle Size

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
edge-ssr.js gzip	2.3 kB	2.3 kB	N/A
page.js gzip	2.99 kB	2.98 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
middleware-b..fest.js gzip	627 B	626 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	464 B	466 B	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
app-page-exp...dev.js gzip	167 kB	167 kB	✓
app-page-exp..prod.js gzip	96.2 kB	96.2 kB	✓
app-page-tur..prod.js gzip	97.9 kB	97.9 kB	✓
app-page-tur..prod.js gzip	92.4 kB	92.4 kB	✓
app-page.run...dev.js gzip	136 kB	136 kB	✓
app-page.run..prod.js gzip	90.9 kB	90.9 kB	✓
app-route-ex...dev.js gzip	22.1 kB	22.1 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.7 kB	14.7 kB	✓
app-route.ru...dev.js gzip	21.8 kB	21.8 kB	✓
app-route.ru..prod.js gzip	14.7 kB	14.7 kB	✓
pages-api-tu..prod.js gzip	9.49 kB	9.49 kB	✓
pages-api.ru...dev.js gzip	9.76 kB	9.76 kB	✓
pages-api.ru..prod.js gzip	9.48 kB	9.48 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	23 kB	23 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.4 kB	50.4 kB	✓
Overall change	930 kB	930 kB	✓

build cache

	vercel/next.js canary	samcx/next.js sam/next-lint-comment	Change
0.pack gzip	1.49 MB	1.49 MB	N/A
index.pack gzip	105 kB	104 kB	N/A
Overall change	0 B	0 B	✓

Commit: 6dd9edd