Handle top level errors coming from Turbopack entrypoints subscription #62528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on |
Merged
Tests Passed |
Stats from current PRDefault BuildGeneral Overall increase
|
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| buildDuration | 13.9s | 13.9s | N/A |
| buildDurationCached | 7.4s | 6.4s | N/A |
| nodeModulesSize | 197 MB | 197 MB | |
| nextStartRea..uration (ms) | 431ms | 425ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| 2453-HASH.js gzip | 30.2 kB | 30.2 kB | N/A |
| 3304.HASH.js gzip | 181 B | 181 B | ✓ |
| 3f784ff6-HASH.js gzip | 53.7 kB | 53.7 kB | N/A |
| 8299-HASH.js gzip | 5.04 kB | 5.04 kB | N/A |
| framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
| main-app-HASH.js gzip | 242 B | 240 B | N/A |
| main-HASH.js gzip | 32.2 kB | 32.2 kB | N/A |
| webpack-HASH.js gzip | 1.68 kB | 1.68 kB | N/A |
| Overall change | 45.4 kB | 45.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 196 B | 197 B | N/A |
| _error-HASH.js gzip | 184 B | 184 B | ✓ |
| amp-HASH.js gzip | 505 B | 505 B | ✓ |
| css-HASH.js gzip | 324 B | 325 B | N/A |
| dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | N/A |
| edge-ssr-HASH.js gzip | 258 B | 258 B | ✓ |
| head-HASH.js gzip | 352 B | 352 B | ✓ |
| hooks-HASH.js gzip | 370 B | 371 B | N/A |
| image-HASH.js gzip | 4.2 kB | 4.2 kB | ✓ |
| index-HASH.js gzip | 259 B | 259 B | ✓ |
| link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 314 B | 312 B | N/A |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 6.56 kB | 6.56 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 483 B | 485 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| index.html gzip | 530 B | 529 B | N/A |
| link.html gzip | 542 B | 542 B | ✓ |
| withRouter.html gzip | 525 B | 523 B | N/A |
| Overall change | 542 B | 542 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 95 kB | 95 kB | N/A |
| page.js gzip | 3.07 kB | 3.07 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 620 B | 624 B | N/A |
| middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
| middleware.js gzip | 25.5 kB | 25.5 kB | N/A |
| edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
| Overall change | 990 B | 990 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 171 kB | 171 kB | ✓ |
| app-page-exp..prod.js gzip | 96.7 kB | 96.7 kB | ✓ |
| app-page-tur..prod.js gzip | 98.5 kB | 98.5 kB | ✓ |
| app-page-tur..prod.js gzip | 92.9 kB | 92.9 kB | ✓ |
| app-page.run...dev.js gzip | 150 kB | 150 kB | ✓ |
| app-page.run..prod.js gzip | 91.4 kB | 91.4 kB | ✓ |
| app-route-ex...dev.js gzip | 21.3 kB | 21.3 kB | ✓ |
| app-route-ex..prod.js gzip | 15 kB | 15 kB | ✓ |
| app-route-tu..prod.js gzip | 15 kB | 15 kB | ✓ |
| app-route-tu..prod.js gzip | 14.8 kB | 14.8 kB | ✓ |
| app-route.ru...dev.js gzip | 20.9 kB | 20.9 kB | ✓ |
| app-route.ru..prod.js gzip | 14.8 kB | 14.8 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.51 kB | 9.51 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.79 kB | 9.79 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.51 kB | 9.51 kB | ✓ |
| pages-turbo...prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
| pages.runtim...dev.js gzip | 23 kB | 23 kB | ✓ |
| pages.runtim..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
| server.runti..prod.js gzip | 50.6 kB | 50.6 kB | ✓ |
| Overall change | 950 kB | 950 kB | ✓ |
build cache
| vercel/next.js canary | vercel/next.js 02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription | Change | |
|---|---|---|---|
| 0.pack gzip | 1.56 MB | 1.56 MB | N/A |
| index.pack gzip | 105 kB | 105 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Diff details
Diff for middleware.js
Diff too large to display
sokra
reviewed
Feb 26, 2024
sokra
approved these changes
Feb 26, 2024
timneutkens
force-pushed
the
02-26-Add_IssueKey_type
branch
from
836fdc6
to
f6e9def
Compare
timneutkens
force-pushed
the
02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription
branch
from
7285591
to
5a26376
Compare
|
Added handling for build 🙌 |
timneutkens
force-pushed
the
02-26-Add_IssueKey_type
branch
from
f6e9def
to
87d84f3
Compare
timneutkens
force-pushed
the
02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription
branch
from
90770f8
to
aa300d7
Compare
timneutkens
force-pushed
the
02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription
branch
2 times, most recently
from
b186df8
to
0d71e34
Compare
|
This is blocked on #62585 as not-found handling causes a conflict |
timneutkens
added a commit
that referenced
this pull request
Feb 29, 2024
## What? #62528 caused test/e2e/app-dir/not-found/conflict-route to fail compilation in Turbopack, this compiler error was previously already reported by Turbopack but Next.js didn't show it, which #62528 resolved. This PR changes the handling for the not-found handling to be consistent between development and build, which ensures that the "special" page no longer conflicts with app/not-found/page.js. Closes NEXT-2617 Note: this is a reworked iteration of #62585 which wasn't sufficient. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
timneutkens
force-pushed
the
02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription
branch
from
0d71e34
to
e8146d1
Compare
timneutkens
force-pushed
the
02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription
branch
from
e8146d1
to
e7b50b9
Compare
timneutkens
requested review from
ismaelrumzan and
delbaoliveira
and removed request for
a team
timneutkens
deleted the
02-26-Handle_top_level_errors_coming_from_Turbopack_entrypoints_subscription
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds handling for issues that are emitted during the entrypoints subscription, before the changes in this PR any issue (i.e. compiler errors) that was emitted during the collection of which entrypoints exist in the application were ignored.
Closes NEXT-2591