Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Turbopack #62632

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Update Turbopack #62632

merged 4 commits into from
Feb 28, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 28, 2024 •
edited by sokra

@kdy1 kdy1 self-assigned this Feb 28, 2024
@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team type: next labels Feb 28, 2024
@kdy1 kdy1 requested a review from a team as a code owner February 28, 2024 07:17
@ijjk
Copy link
Member

ijjk commented Feb 28, 2024 •
edited

Failing test suites

Commit: 55ad9d1

TURBOPACK=1 pnpm test test/integration/edge-runtime-module-errors/test/index.test.js (turbopack)

  • Edge runtime code with imports > Edge API using Buffer polyfill > does not throw in dev at runtime
  • Edge runtime code with imports > Middleware using Buffer polyfill > does not throw in dev at runtime
Expand output

● Edge runtime code with imports › Edge API using Buffer polyfill › does not throw in dev at runtime

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  389 |       context.app = await launchApp(context.appDir, context.appPort, appOption)
  390 |       const res = await fetchViaHTTP(context.appPort, url)
> 391 |       expect(res.status).toBe(200)
      |                          ^
  392 |       expect(res.headers.get('x-from-runtime')).toBe('false')
  393 |       expectNoError(moduleName)
  394 |     })

  at Object.toBe (integration/edge-runtime-module-errors/test/index.test.js:391:26)

● Edge runtime code with imports › Middleware using Buffer polyfill › does not throw in dev at runtime

expect(received).toBe(expected) // Object.is equality

Expected: 200
Received: 500

  389 |       context.app = await launchApp(context.appDir, context.appPort, appOption)
  390 |       const res = await fetchViaHTTP(context.appPort, url)
> 391 |       expect(res.status).toBe(200)
      |                          ^
  392 |       expect(res.headers.get('x-from-runtime')).toBe('false')
  393 |       expectNoError(moduleName)
  394 |     })

  at Object.toBe (integration/edge-runtime-module-errors/test/index.test.js:391:26)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test test/integration/react-streaming/test/index.test.js (turbopack)

  • streaming dev dev > should support streaming for fizz response
  • streaming dev dev > should not stream to crawlers or google pagerender bot
  • streaming dev dev > should render 500 error correctly
  • streaming dev dev > should render fallback if error raised from suspense during streaming
Expand output

● streaming dev dev › should support streaming for fizz response

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  43 |           // Streaming is disabled for pages, no fallback should be rendered.
  44 |           expect(gotFallback).toBe(false)
> 45 |           expect(gotData).toBe(true)
     |                           ^
  46 |         }
  47 |       )
  48 |

  at toBe (integration/react-streaming/test/streaming.js:45:27)
  at testStreamingResponse (integration/react-streaming/test/streaming.js:28:7)
  at Object.<anonymous> (integration/react-streaming/test/streaming.js:55:5)

● streaming dev dev › should not stream to crawlers or google pagerender bot

expect(received).toBe(expected) // Object.is equality

Expected: "next_streaming_data"
Received: ""

  88 |     const body = await getNodeBySelector(html, '#__next')
  89 |     // Resolve data instead of fallback
> 90 |     expect(body.text()).toBe('next_streaming_data')
     |                         ^
  91 |
  92 |     expect(res1.headers.get('etag')).toBeDefined()
  93 |     expect(res2.headers.get('etag')).toBeDefined()

  at Object.toBe (integration/react-streaming/test/streaming.js:90:25)

● streaming dev dev › should render 500 error correctly

expect(received).toContain(expected) // indexOf

Expected substring: "Error: oops"
Received string:    "<!DOCTYPE html><html><head><style data-next-hide-fouc=\"true\">body{display:none}</style><noscript data-next-hide-fouc=\"true\"><style>body{display:block}</style></noscript><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><script src=\"/_next/static/chunks/%5Broot%20of%20the%20server%5D__ea7a8f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/2c7be_react_22c55a._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/4f707_react-dom_cjs_react-dom_development_c0b264.js\" defer=\"\"></script><script src=\"/_next/static/chunks/4f707_react-dom_55c180._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/08b5e__pnpm_762be9._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_30f76f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_b23682._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_92164f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Broot%20of%20the%20server%5D__0158e1._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_aa3b78._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_ae0469._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_b8f857._.js\" defer=\"\"></script><script src=\"/_next/static/development/_ssgManifest.js\" defer=\"\"></script><script src=\"/_next/static/development/_buildManifest.js\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body><div id=\"__next\"></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"err\":{\"name\":\"TypeError\",\"source\":\"edge-server\",\"message\":\"__turbopack_external_require__ is not a function\",\"stack\":\"TypeError: __turbopack_external_require__ is not a function\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_14f3ca._.js:7841:57)\\n    at [project]/packages/next/dist/esm/server/base-server.js [edge-ssr] (ecmascript) (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_14f3ca._.js:9960:3)\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_5b5584.js:509:27)\\n    at runModuleExecutionHooks (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_5b5584.js:550:9)\\n    at instantiateModule (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_5b5584.js:508:9)\\n    at getOrInstantiateModuleFromParent (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_5b5584.js:582:12)\\n    at esmImport (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_5b5584.js:123:20)\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_14f3ca._.js:11783:164)\\n    at [project]/packages/next/dist/esm/server/web-server.js [edge-ssr] (ecmascript) (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_14f3ca._.js:12045:3)\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_5b5584.js:509:27)\"},\"gip\":true,\"scriptLoader\":[]}</script></body></html>"

  100 |       if (env === 'dev') {
  101 |         // In dev mode it should show the error popup.
> 102 |         expect(html).toContain('Error: oops')
      |                      ^
  103 |       } else {
  104 |         expect(html).toContain('custom-500-page')
  105 |       }

  at toContain (integration/react-streaming/test/streaming.js:102:22)
      at async Promise.all (index 1)
  at Object.<anonymous> (integration/react-streaming/test/streaming.js:107:5)

● streaming dev dev › should render fallback if error raised from suspense during streaming

expect(received).toContain(expected) // indexOf

Expected substring: "error-fallback"
Received string:    "<!DOCTYPE html><html><head><style data-next-hide-fouc=\"true\">body{display:none}</style><noscript data-next-hide-fouc=\"true\"><style>body{display:block}</style></noscript><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><script src=\"/_next/static/chunks/%5Broot%20of%20the%20server%5D__ea7a8f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/2c7be_react_22c55a._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/4f707_react-dom_cjs_react-dom_development_c0b264.js\" defer=\"\"></script><script src=\"/_next/static/chunks/4f707_react-dom_55c180._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/08b5e__pnpm_762be9._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_30f76f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_b23682._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_92164f._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Broot%20of%20the%20server%5D__0158e1._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bproject%5D_packages_next_dist_pages_aa3b78._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_ae0469._.js\" defer=\"\"></script><script src=\"/_next/static/chunks/%5Bnext%5D_entry_page-loader_ts_b8f857._.js\" defer=\"\"></script><script src=\"/_next/static/development/_ssgManifest.js\" defer=\"\"></script><script src=\"/_next/static/development/_buildManifest.js\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body><div id=\"__next\"></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"err\":{\"name\":\"TypeError\",\"source\":\"edge-server\",\"message\":\"__turbopack_external_require__ is not a function\",\"stack\":\"TypeError: __turbopack_external_require__ is not a function\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_608d46._.js:7841:57)\\n    at [project]/packages/next/dist/esm/server/base-server.js [edge-ssr] (ecmascript) (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_608d46._.js:9960:3)\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_75d1b2.js:509:27)\\n    at runModuleExecutionHooks (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_75d1b2.js:550:9)\\n    at instantiateModule (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_75d1b2.js:508:9)\\n    at getOrInstantiateModuleFromParent (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_75d1b2.js:582:12)\\n    at esmImport (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_75d1b2.js:123:20)\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_608d46._.js:11783:164)\\n    at [project]/packages/next/dist/esm/server/web-server.js [edge-ssr] (ecmascript) (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/[project]_packages_next_dist_esm_608d46._.js:12045:3)\\n    at \\u003cunknown\\u003e (file:///root/actions-runner/_work/next.js/next.js/test/integration/react-streaming/app/.next/server/edge/chunks/edge-wrapper_75d1b2.js:509:27)\"},\"gip\":true,\"scriptLoader\":[]}</script></body></html>"

  110 |   it('should render fallback if error raised from suspense during streaming', async () => {
  111 |     const html = await renderViaHTTP(context.appPort, '/err/suspense')
> 112 |     expect(html).toContain('error-fallback')
      |                  ^
  113 |   })
  114 | }
  115 |

  at Object.toContain (integration/react-streaming/test/streaming.js:112:18)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Feb 28, 2024 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
buildDuration 14s 14s N/A
buildDurationCached 7.5s 6.3s N/A
nodeModulesSize 197 MB 197 MB ✓
nextStartRea..uration (ms) 411ms 429ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.6 kB 45.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.56 kB 6.56 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.05 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
middleware-b..fest.js gzip 625 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
app-page-exp...dev.js gzip 171 kB 171 kB ✓
app-page-exp..prod.js gzip 96.7 kB 96.7 kB ✓
app-page-tur..prod.js gzip 98.5 kB 98.5 kB ✓
app-page-tur..prod.js gzip 92.9 kB 92.9 kB ✓
app-page.run...dev.js gzip 150 kB 150 kB ✓
app-page.run..prod.js gzip 91.4 kB 91.4 kB ✓
app-route-ex...dev.js gzip 21.3 kB 21.3 kB ✓
app-route-ex..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 15 kB 15 kB ✓
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 20.9 kB 20.9 kB ✓
app-route.ru..prod.js gzip 14.8 kB 14.8 kB ✓
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB ✓
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB ✓
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB ✓
pages-turbo...prod.js gzip 22.3 kB 22.3 kB ✓
pages.runtim...dev.js gzip 23 kB 23 kB ✓
pages.runtim..prod.js gzip 22.3 kB 22.3 kB ✓
server.runti..prod.js gzip 50.6 kB 50.6 kB ✓
Overall change 950 kB 950 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/update-turbopack-2 Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 105 kB ⚠️ +836 B
Overall change 105 kB 105 kB ⚠️ +836 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: c3d6aa8

@kdy1 kdy1 enabled auto-merge (squash) February 28, 2024 08:16
@kdy1 kdy1 merged commit 9408f35 into canary Feb 28, 2024
71 checks passed
@kdy1 kdy1 deleted the kdy1/update-turbopack-2 branch February 28, 2024 08:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the turbopack team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kdy1 @ijjk @sokra