Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental config for navigation raf test #62668

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 29, 2024

This adds a new experimental config for testing.

x-ref: slack thread

Closes NEXT-2644

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 29, 2024
@ijjk
Copy link
Member Author

ijjk commented Feb 29, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/experimental-raf Change
buildDuration 14s 14.1s ⚠️ +111ms
buildDurationCached 8.7s 6.4s N/A
nodeModulesSize 197 MB 197 MB ⚠️ +8.87 kB
nextStartRea..uration (ms) 408ms 406ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js add/experimental-raf Change
2453-HASH.js gzip 30.4 kB 30.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/experimental-raf Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js add/experimental-raf Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js add/experimental-raf Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/experimental-raf Change
index.html gzip 528 B 528 B
link.html gzip 541 B 539 B N/A
withRouter.html gzip 525 B 523 B N/A
Overall change 528 B 528 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js add/experimental-raf Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js add/experimental-raf Change
middleware-b..fest.js gzip 626 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary ijjk/next.js add/experimental-raf Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 150 kB 150 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.7 kB 50.7 kB
Overall change 950 kB 950 kB
build cache Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/experimental-raf Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +1.52 kB
index.pack gzip 105 kB 104 kB N/A
Overall change 1.56 MB 1.56 MB ⚠️ +1.52 kB
Diff details
Diff for page.js

Diff too large to display

Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: 1413a06

@ijjk ijjk marked this pull request as ready for review February 29, 2024 00:40
@ijjk ijjk marked this pull request as draft February 29, 2024 08:21
@ijjk ijjk marked this pull request as ready for review February 29, 2024 15:53
@ijjk ijjk requested a review from cramforce February 29, 2024 15:53
@ijjk ijjk merged commit 2bdcaa0 into vercel:canary Feb 29, 2024
63 checks passed
@ijjk ijjk deleted the add/experimental-raf branch February 29, 2024 16:30
@franky47
Copy link
Contributor

FYI, using this flag breaks the use of startTransition in nuqs: https://github.com/47ng/nuqs/actions/runs/8102536596/job/22145237505

The test in question calls the startTransition function of a React.useTransition hook when a search param is updated (using a router.replace call to refresh the RSC payload). Without the flag, the isLoading boolean switches correctly to true and back to false when the RSC payload has been received, but with the flag it never goes to true.

ijjk added a commit to ijjk/next.js that referenced this pull request Mar 4, 2024
This reverts commit 2bdcaa0.

# Conflicts:
#	packages/next/src/server/config-schema.ts
@ijjk
Copy link
Member Author

ijjk commented Mar 4, 2024

Hi, thanks for providing that info! This was just a test so won't be affecting applications and to be safe we are removing this so it doesn't get leveraged

x-ref: #62834

@franky47
Copy link
Contributor

franky47 commented Mar 4, 2024

Thanks for the follow-up!

Any ETA on 14.1.2? The partial 14.1.1 was still missing a good chunk of PRs, some of which impact nuqs and shallow routing in general (see #62098 (comment)).

ijjk added a commit that referenced this pull request Mar 4, 2024
…2834)

Reverting this experimental flag as it should not be used and we are
going to investigate experimenting with this further upstream so that it
can be done properly.

This reverts commit 2bdcaa0.

x-ref: #62668



Closes NEXT-2689
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants