Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ensure dynamic routes dont match _next/static unexpectedly" #62691

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 29, 2024

Reverting temporarily to allow investigation into separate issue eliminating this as also an issue.

Reverts #62559

Copy link

linear bot commented Feb 29, 2024

Issue reopened: CSM-11 Fixing Catch All Routes - Sonos

Copy link

linear bot commented Feb 29, 2024

@ijjk
Copy link
Member Author

ijjk commented Feb 29, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
buildDuration 13.7s 13.8s N/A
buildDurationCached 7.3s 6.2s N/A
nodeModulesSize 197 MB 197 MB N/A
nextStartRea..uration (ms) 429ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
2453-HASH.js gzip 30.4 kB 30.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 525 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
edge-ssr.js gzip 95.1 kB 95 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
middleware-b..fest.js gzip 627 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 150 kB 150 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.7 kB 50.6 kB N/A
Overall change 899 kB 899 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js revert-62559-fix/dynamic-route-matchers Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +932 B
index.pack gzip 105 kB 105 kB N/A
Overall change 1.56 MB 1.56 MB ⚠️ +932 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: c8357c4

@ijjk ijjk merged commit 01b9603 into canary Feb 29, 2024
69 of 70 checks passed
@ijjk ijjk deleted the revert-62559-fix/dynamic-route-matchers branch February 29, 2024 16:34
@laugharn
Copy link
Contributor

@ijjk can confirm this fixes an issue that I was building a repro for, where next-sanity was not rendering in a catch-all route.

@ijjk
Copy link
Member Author

ijjk commented Feb 29, 2024

@laugharn the revert fixed it or the original patch fixed it? Also was that locally or when deployed?

@laugharn
Copy link
Contributor

@ijjk the revert fixed it. It ran locally (with and without Turbopack) but did not build as expected with canary.77-80. Screenshot of the result pre-revert:

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants