Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-lint): do not pass absolute path to distDir #62797

Merged
merged 2 commits into from
Mar 4, 2024
Merged

fix(next-lint): do not pass absolute path to distDir #62797

merged 2 commits into from
Mar 4, 2024

Conversation

devjiwonchoi
Copy link
Contributor

This PR reverts part of #61877 passing an absolute path to the distDir value when running next lint.

Fixes #62796

@ijjk
Copy link
Member

ijjk commented Mar 4, 2024

Allow CI Workflow Run

  • approve CI run for commit: c42b1ea

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Mar 4, 2024

Allow CI Workflow Run

  • approve CI run for commit: c42b1ea

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr: and catching this!

:lgtm:

@samcx samcx enabled auto-merge (squash) March 4, 2024 23:44
@ijjk
Copy link
Member

ijjk commented Mar 4, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
buildDuration 18.7s 18.4s N/A
buildDurationCached 10.4s 9s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 510ms 521ms N/A
Client Bundles (main, webpack)
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
2453-HASH.js gzip 30.2 kB 30.2 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.6 kB 45.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 523 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
edge-ssr.js gzip 95 kB 95 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
middleware-b..fest.js gzip 624 B 622 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 150 kB 150 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 20.9 kB 20.9 kB
app-route.ru..prod.js gzip 14.7 kB 14.7 kB
pages-api-tu..prod.js gzip 9.51 kB 9.51 kB
pages-api.ru...dev.js gzip 9.79 kB 9.79 kB
pages-api.ru..prod.js gzip 9.51 kB 9.51 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.6 kB 50.6 kB
Overall change 950 kB 950 kB
build cache Overall increase ⚠️
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-adds-unnecessary-include Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 106 kB ⚠️ +580 B
Overall change 105 kB 106 kB ⚠️ +580 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 08c4ce0

@samcx samcx merged commit 882aa6d into vercel:canary Mar 4, 2024
61 checks passed
@devjiwonchoi devjiwonchoi deleted the fix/next-lint-adds-unnecessary-include branch March 5, 2024 01:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next lint adds unnecessary absolute path distDir to include in tsconfig.json
3 participants