fix(turbopack): Remove error overlay when issue is resolved

[kdy1]

What?

Subscribe to changes of _error pages.

Why?

To make the error overlay disappear when the error is fixed.

I tried skipping related entries by using continue; from

next.js/packages/next/src/server/dev/hot-reloader-turbopack.ts

Lines 675 to 684 in 5f3b135

	const errors = []
	for (const issue of topLevelIssues) {
	errors.push(new Error(formatIssue(issue)))
	}
	for (const entryIssues of currentEntryIssues.values()) {
	for (const issue of entryIssues.values()) {
	errors.push(new Error(formatIssue(issue)))
	}
	}
	return errors

, but it resulted in it page being rendered in the background while error overlay does not disappear.

We need to remove the errors from /_error page to make the error overlay disappear, so I tried removing them from the map and it worked.

How?

Closes PACK-2405
Closes PACK-2644

[ijjk]

Failing test suites

Commit: f2be1fc

pnpm test-dev test/e2e/app-dir/rsc-basic/rsc-basic.test.ts (PPR)

• app dir - rsc basics > should be able to navigate between rsc routes

Expand output

● app dir - rsc basics › should be able to navigate between rsc routes

request.allHeaders: Target page, context or browser has been closed

  145 |           page.on('request', (request) => {
  146 |             requestsCount++
> 147 |             return request.allHeaders().then((headers) => {
      |                            ^
  148 |               if (
  149 |                 headers['RSC'.toLowerCase()] === '1' &&
  150 |                 // Prefetches also include `RSC`

  at Page.allHeaders (e2e/app-dir/rsc-basic/rsc-basic.test.ts:147:28)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
buildDuration	13.9s	13.7s	N/A
buildDurationCached	7.4s	6.3s	N/A
nodeModulesSize	198 MB	198 MB	⚠️ +2.81 kB
nextStartRea..uration (ms)	436ms	445ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
2453-HASH.js gzip	30.4 kB	30.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	N/A
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	242 B	✓
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	45.6 kB	45.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
index.html gzip	529 B	529 B	✓
link.html gzip	542 B	541 B	N/A
withRouter.html gzip	525 B	523 B	N/A
Overall change	529 B	529 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
edge-ssr.js gzip	95.1 kB	95.1 kB	N/A
page.js gzip	3.05 kB	3.05 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
middleware-b..fest.js gzip	626 B	625 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
app-page-exp...dev.js gzip	171 kB	171 kB	✓
app-page-exp..prod.js gzip	96.6 kB	96.6 kB	✓
app-page-tur..prod.js gzip	98.3 kB	98.3 kB	✓
app-page-tur..prod.js gzip	92.8 kB	92.8 kB	✓
app-page.run...dev.js gzip	149 kB	149 kB	✓
app-page.run..prod.js gzip	91.3 kB	91.3 kB	✓
app-route-ex...dev.js gzip	21.3 kB	21.3 kB	✓
app-route-ex..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	15 kB	15 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	21 kB	21 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.52 kB	9.52 kB	✓
pages-api.ru...dev.js gzip	9.8 kB	9.8 kB	✓
pages-api.ru..prod.js gzip	9.52 kB	9.52 kB	✓
pages-turbo...prod.js gzip	22.3 kB	22.3 kB	✓
pages.runtim...dev.js gzip	22.9 kB	22.9 kB	✓
pages.runtim..prod.js gzip	22.3 kB	22.3 kB	✓
server.runti..prod.js gzip	50.6 kB	50.6 kB	✓
Overall change	948 kB	948 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js kdy1/pack-2405	Change
0.pack gzip	1.55 MB	1.55 MB	⚠️ +103 B
index.pack gzip	105 kB	105 kB	N/A
Overall change	1.55 MB	1.55 MB	⚠️ +103 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: f2be1fc

[sokra]

This will just always reload the page on HMR events

[ForsakenHarmony]

This feels wrong to me, I also don't think app has a _error route.

We might just want to subscribe to changes of the _error page.

[ForsakenHarmony]

Pushed my suggestion above as that seemed like the easiest way to show what I meant