fix(next): next build --debug log output layout is broken
#63193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devjiwonchoi
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
ztanner,
feedthejim,
a team and
wyattjoh
as code owners
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
devjiwonchoi
commented
Mar 12, 2024
| @@ -824,9 +823,10 @@ export function printCustomRoutes({ | |||
| }) | |||
| .join('\n') | |||
|
|
|||
| print(routesStr, '\n') | |||
| print(`${routesStr}\n`) | |||
There was a problem hiding this comment.
Note that print is just a console.log.
It was adding a single space after routeStr, think of console.log('a', 'b').
Why modify it? For better output string match.
| } | ||
|
|
||
| print() |
There was a problem hiding this comment.
Ensure two line breaks (marked as > below) for each option:
Headers
┌ source: /
└ headers:
└ x-custom-headers: headers
>
>
Rewrites
┌ source: /rewrites
└ destination: /There was a problem hiding this comment.
@huozhi, sorry to ping you, but wanted to ask you whether two line breaks are OK since I believe you have good aesthetics.
| output = stripAnsi(next.cliOutput) | ||
| }) | ||
| describe('production - app dir - build output', () => { | ||
| const { next } = nextTestSetup({ |
There was a problem hiding this comment.
Refactored previous build output test to use nextTestSetup
devjiwonchoi
changed the title
--debug was unorganizednext build --debug log output layout is broken
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display |
ijjk
approved these changes
Apr 2, 2024
|
Thank you for reviewing!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The output layout breaks when running
next build --debugCurrent
Expected
✓ Generating static pages (4/4) Finalizing page optimization ... Collecting build traces ... Redirects ┌ source: /:path+/ ├ destination: /:path+ └ permanent: trueHow?
Moved the
debugoutput right above theroutesoutput.Also, ensured that the output layout has a consistent number of line breaks (example below marked as
>):Fixes #63192