Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for assets in edge #63209

Merged
merged 3 commits into from
Mar 12, 2024
Merged

add support for assets in edge #63209

merged 3 commits into from
Mar 12, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Mar 12, 2024

What?

add support for new URL(..., import.meta.url) assets in edge. e. g. needed for og-image.

Why?

Turbopack Changes

Closes PACK-2725

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Mar 12, 2024
@sokra sokra changed the title Sokra/edge assets add support for assets in edge Mar 12, 2024
@sokra sokra requested a review from kwonoj March 12, 2024 20:57
@ijjk
Copy link
Member

ijjk commented Mar 12, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js sokra/edge-assets Change
buildDuration 13.9s 13.9s N/A
buildDurationCached 7.4s 6.1s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 429ms 428ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/edge-assets Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 240 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/edge-assets Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/edge-assets Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/edge-assets Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/edge-assets Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 523 B 523 B
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/edge-assets Change
edge-ssr.js gzip 95.1 kB 95.1 kB N/A
page.js gzip 3.07 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/edge-assets Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/edge-assets Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.6 kB 96.6 kB
app-page-tur..prod.js gzip 98.3 kB 98.3 kB
app-page-tur..prod.js gzip 92.8 kB 92.8 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.3 kB 91.3 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 22.9 kB 22.9 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.5 kB 50.5 kB N/A
Overall change 897 kB 897 kB
build cache
vercel/next.js canary vercel/next.js sokra/edge-assets Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 106 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 93c19fc

@ijjk
Copy link
Member

ijjk commented Mar 12, 2024

Failing test suites

Commit: a74574b

pnpm test test/integration/prerender-export/test/index.test.js

Expand output

● Test suite failed to run

thrown: "Exceeded timeout of 60000 ms for a hook.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  217 |       })
  218 |
> 219 |       afterAll(async () => {
      |       ^
  220 |         if (app) {
  221 |           await stopApp(app)
  222 |         }

  at afterAll (integration/prerender-export/test/index.test.js:219:7)
  at describe (integration/prerender-export/test/index.test.js:209:5)
  at integration/prerender-export/test/index.test.js:208:52
  at Object.describe (integration/prerender-export/test/index.test.js:207:1)

Read more about building and testing Next.js in contributing.md.

@sokra sokra enabled auto-merge (squash) March 12, 2024 21:23
@sokra sokra merged commit 18547d5 into canary Mar 12, 2024
65 of 68 checks passed
@sokra sokra deleted the sokra/edge-assets branch March 12, 2024 21:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants