Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSC etag generation handling #63336

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Update RSC etag generation handling #63336

merged 5 commits into from
Mar 19, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 15, 2024

Currently when we generate payloads in app router, the order of RSC chunks aren't deterministic even if the content stays the same. This means that any caches that rely on etags for detecting changes in content aren't able to reliably cache/and avoid invalidating properly. To avoid this we can manually sort the content before generating the etag. Eventually this can be fixed upstream in react although that is a bigger lift so we are doing this for now to alleviate the issue.

x-ref: slack thread

Closes NEXT-2825

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 15, 2024
@ijjk
Copy link
Member Author

ijjk commented Mar 15, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js update/rsc-etag Change
buildDuration 14s 13.8s N/A
buildDurationCached 7.4s 6.3s N/A
nodeModulesSize 198 MB 198 MB ⚠️ +33.2 kB
nextStartRea..uration (ms) 441ms 445ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js update/rsc-etag Change
2453-HASH.js gzip 30.7 kB 30.7 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js update/rsc-etag Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js update/rsc-etag Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js update/rsc-etag Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js update/rsc-etag Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js update/rsc-etag Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.04 kB 3.04 kB
Overall change 3.04 kB 3.04 kB
Middleware size
vercel/next.js canary vercel/next.js update/rsc-etag Change
middleware-b..fest.js gzip 625 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js update/rsc-etag Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 98.6 kB 98.6 kB
app-page-tur..prod.js gzip 93.1 kB 93.1 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.6 kB 91.6 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.54 kB N/A
pages-api.ru...dev.js gzip 9.8 kB 9.81 kB N/A
pages-api.ru..prod.js gzip 9.52 kB 9.54 kB N/A
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 50.7 kB 50.9 kB ⚠️ +230 B
Overall change 916 kB 916 kB ⚠️ +230 B
build cache
vercel/next.js canary vercel/next.js update/rsc-etag Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 106 kB 105 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for pages-api-tu..time.prod.js

Diff too large to display

Diff for pages-api.runtime.dev.js

Diff too large to display

Diff for pages-api.ru..time.prod.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: e38b693

@ijjk ijjk marked this pull request as ready for review March 19, 2024 21:21
@ijjk ijjk requested a review from Timer March 19, 2024 21:26
@ijjk ijjk enabled auto-merge (squash) March 19, 2024 21:33
@ijjk ijjk merged commit d4f5368 into canary Mar 19, 2024
71 of 76 checks passed
@ijjk ijjk deleted the update/rsc-etag branch March 19, 2024 21:45
@github-actions github-actions bot added the locked label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants