Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify createRootLayoutValidatorStream #63484

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

Ethan-Arrowood
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood commented Mar 19, 2024

This PR is a follow up to #63427 and simplifies the createRootLayoutValidatorStream function to check each chunk individually instead of combining all of them into one. This should improve performance

Closes NEXT-2868

@ijjk
Copy link
Member

ijjk commented Mar 19, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
buildDuration 14s 14.1s ⚠️ +109ms
buildDurationCached 7.5s 6.3s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 437ms 437ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
edge-ssr.js gzip 95.4 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
app-page-exp...dev.js gzip 170 kB 170 kB N/A
app-page-exp..prod.js gzip 96.9 kB 96.8 kB N/A
app-page-tur..prod.js gzip 98.6 kB 98.6 kB N/A
app-page-tur..prod.js gzip 93.1 kB 93 kB N/A
app-page.run...dev.js gzip 144 kB 144 kB N/A
app-page.run..prod.js gzip 91.6 kB 91.5 kB N/A
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.5 kB 22.4 kB N/A
pages.runtim...dev.js gzip 23.1 kB 23.1 kB N/A
pages.runtim..prod.js gzip 22.5 kB 22.4 kB N/A
server.runti..prod.js gzip 50.7 kB 50.7 kB
Overall change 181 kB 181 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js simplify-root-layout-validator-stream Change
0.pack gzip 1.56 MB 1.55 MB N/A
index.pack gzip 105 kB 105 kB ⚠️ +136 B
Overall change 105 kB 105 kB ⚠️ +136 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Diff for pages-turbo...time.prod.js

Diff too large to display

Diff for pages.runtime.dev.js

Diff too large to display

Diff for pages.runtime.prod.js

Diff too large to display

Commit: 836c855

@ijjk
Copy link
Member

ijjk commented Mar 19, 2024

Tests Passed

@Fonger
Copy link
Contributor

Fonger commented Mar 19, 2024

There's typo in the title of this PR

@Ethan-Arrowood Ethan-Arrowood changed the title Simplify creaetRootLayoutValidatorStream Simplify createRootLayoutValidatorStream Mar 19, 2024
@Ethan-Arrowood Ethan-Arrowood enabled auto-merge (squash) March 19, 2024 19:17
@Ethan-Arrowood Ethan-Arrowood merged commit d2838ce into canary Mar 19, 2024
77 checks passed
@Ethan-Arrowood Ethan-Arrowood deleted the simplify-root-layout-validator-stream branch March 19, 2024 21:46
@github-actions github-actions bot added the locked label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants