Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tags limit handling for max items #63486

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 19, 2024

Continuation of #55083 this ensures we also properly warn when the max number of tags is hit and we must filter them out so that users are aware of this. Related documentation is also updated to reflect this limit.

x-ref: slack thread

Closes NEXT-2870

@ijjk ijjk marked this pull request as ready for review March 19, 2024 17:43
@ijjk ijjk removed the request for review from a team March 19, 2024 17:43
@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Mar 19, 2024
@ijjk ijjk requested a review from ismaelrumzan March 19, 2024 17:43
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this new behavior?

@ijjk
Copy link
Member Author

ijjk commented Mar 19, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
buildDuration 14.1s 13.9s N/A
buildDurationCached 8.5s 6.2s N/A
nodeModulesSize 198 MB 198 MB ⚠️ +19 kB
nextStartRea..uration (ms) 437ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 98.6 kB 98.6 kB
app-page-tur..prod.js gzip 93.1 kB 93.1 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.6 kB 91.6 kB
app-route-ex...dev.js gzip 21.3 kB 21.4 kB N/A
app-route-ex..prod.js gzip 15 kB 15.1 kB N/A
app-route-tu..prod.js gzip 15 kB 15.1 kB N/A
app-route-tu..prod.js gzip 14.8 kB 14.8 kB N/A
app-route.ru...dev.js gzip 21 kB 21 kB N/A
app-route.ru..prod.js gzip 14.8 kB 14.8 kB N/A
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 50.7 kB 50.7 kB
Overall change 842 kB 842 kB
build cache
vercel/next.js canary ijjk/next.js update/tags-limit-handling Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 105 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: ded18e9

ijjk and others added 2 commits March 19, 2024 10:58
Co-authored-by: Steven <steven@ceriously.com>
@ijjk ijjk requested a review from styfle March 19, 2024 18:17
ijjk and others added 2 commits March 19, 2024 11:36
Co-authored-by: Steven <steven@ceriously.com>
@ijjk ijjk merged commit b2b5ab4 into vercel:canary Mar 19, 2024
70 checks passed
@ijjk ijjk deleted the update/tags-limit-handling branch March 19, 2024 19:02
@github-actions github-actions bot added the locked label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants