Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-core): support unsupported module runtime error #63491

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Mar 19, 2024

What

Implement webpack's middleware plugin equivalent for Turbopack, to raise unsupported error in runtime.

PR utilizes import map alias for the edge context, to resolve into modulereplacer internally provides a virtualsource to call runtime error logic. Since we already have globally augmented, the virtualsource only need to take export those into module.

Closes PACK-2789

@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Mar 19, 2024
@ijjk
Copy link
Member

ijjk commented Mar 19, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Mar 19, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js edge-unsupported-node Change
buildDuration 13.8s 13.9s N/A
buildDurationCached 7.4s 6.1s N/A
nodeModulesSize 198 MB 198 MB
nextStartRea..uration (ms) 414ms 431ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js edge-unsupported-node Change
2453-HASH.js gzip 30.7 kB 30.7 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 243 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js edge-unsupported-node Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js edge-unsupported-node Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js edge-unsupported-node Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js edge-unsupported-node Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js edge-unsupported-node Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js edge-unsupported-node Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary vercel/next.js edge-unsupported-node Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 98.6 kB 98.6 kB
app-page-tur..prod.js gzip 93.1 kB 93.1 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.6 kB 91.6 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.52 kB 9.52 kB
pages-api.ru...dev.js gzip 9.8 kB 9.8 kB
pages-api.ru..prod.js gzip 9.52 kB 9.52 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 50.7 kB 50.7 kB
Overall change 945 kB 945 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js edge-unsupported-node Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +679 B
index.pack gzip 106 kB 105 kB N/A
Overall change 1.56 MB 1.56 MB ⚠️ +679 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: b60ecbe

@kwonoj kwonoj force-pushed the edge-unsupported-node branch 5 times, most recently from f1f7ace to 936906c Compare March 19, 2024 19:57
@kwonoj kwonoj marked this pull request as ready for review March 19, 2024 20:32
@kwonoj kwonoj merged commit 3689c03 into canary Mar 19, 2024
77 checks passed
@kwonoj kwonoj deleted the edge-unsupported-node branch March 19, 2024 20:52
kwonoj added a commit that referenced this pull request Mar 20, 2024
### What
Followup for #63491, adjust
fixture setup to work with turbopack.

Closes PACK-2790
sokra added a commit that referenced this pull request Mar 21, 2024
…3491)" (#63575)

### What?

It's causing `__import_unsupported` is not defined in `instrumentation`
context
kwonoj added a commit that referenced this pull request Mar 22, 2024
…rror (#63491)"" (#63609)

### What

This PR reenables reverted PR #63491, with fixing unexpectedly mark
supported node.js internals as unsupported.

Tried to add test cases for the supported case but hitting
https://vercel.slack.com/archives/C03EWR7LGEN/p1711128538909549, need
separate investigation.
@github-actions github-actions bot added the locked label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants