Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for react-dom react-server condition #63588

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Mar 22, 2024

react-dom also contains a react-server condition that need to be picked up in RSC bundle layer, like what we did for react. This will ensures the server runtime smaller and you don't accidentally use the client apis on server side.

Closes NEXT-2898

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 22, 2024
@huozhi huozhi force-pushed the fix/missing-react-dom-alias branch from ed2641d to 2b9b2bc Compare March 22, 2024 00:21
@huozhi huozhi marked this pull request as ready for review March 22, 2024 00:25
@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
buildDuration 13.7s 14s ⚠️ +281ms
buildDurationCached 8.4s 6.2s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 429ms 431ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
2453-HASH.js gzip 30.8 kB 30.8 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 240 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
index.html gzip 530 B 527 B N/A
link.html gzip 542 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
app-page-exp...dev.js gzip 170 kB 170 kB N/A
app-page-exp..prod.js gzip 96.9 kB 96.8 kB N/A
app-page-tur..prod.js gzip 98.6 kB 98.5 kB N/A
app-page-tur..prod.js gzip 93.1 kB 92.8 kB N/A
app-page.run...dev.js gzip 144 kB 144 kB N/A
app-page.run..prod.js gzip 91.6 kB 91.3 kB N/A
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 50.9 kB 50.9 kB
Overall change 250 kB 250 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias Change
0.pack gzip 1.56 MB 1.56 MB ⚠️ +781 B
index.pack gzip 106 kB 105 kB N/A
Overall change 1.56 MB 1.56 MB ⚠️ +781 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js

Diff too large to display

Commit: eeac595

@huozhi huozhi marked this pull request as draft March 22, 2024 00:31
@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: c416530

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: eeac595

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@lubieowoce lubieowoce force-pushed the fix/missing-react-dom-alias branch 2 times, most recently from 491540d to 9b6edc3 Compare March 22, 2024 13:24
@gnoff gnoff marked this pull request as ready for review March 22, 2024 16:37
@gnoff gnoff marked this pull request as draft March 22, 2024 16:39
@gnoff gnoff added the CI approved Approve running CI for fork label Mar 22, 2024
@gnoff gnoff marked this pull request as ready for review March 22, 2024 17:13
@gnoff gnoff merged commit 8e8a86e into canary Mar 22, 2024
95 checks passed
@gnoff gnoff deleted the fix/missing-react-dom-alias branch March 22, 2024 17:21
lubieowoce added a commit that referenced this pull request Mar 25, 2024
Follow up to #63588, we missed edge there

Closes NEXT-2905
@github-actions github-actions bot added the locked label Apr 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants