Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSC react-dom aliases for edge #63619

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

lubieowoce
Copy link
Member

@lubieowoce lubieowoce commented Mar 22, 2024

Follow up to #63588, checking to see if we missed some stuff

Closes NEXT-2905

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team type: next labels Mar 22, 2024
@lubieowoce lubieowoce force-pushed the fix/missing-react-dom-alias-edge branch from 76d742e to 76561de Compare March 22, 2024 19:19
@ijjk
Copy link
Member

ijjk commented Mar 22, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
buildDuration 13.7s 13.8s N/A
buildDurationCached 7.4s 6.2s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 428ms 433ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
2453-HASH.js gzip 30.8 kB 30.8 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
index.html gzip 530 B 528 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 525 B 523 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 96.8 kB 96.8 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.8 kB 92.8 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.3 kB 91.3 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 50.9 kB 50.9 kB
Overall change 943 kB 943 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/missing-react-dom-alias-edge Change
0.pack gzip 1.57 MB 1.56 MB N/A
index.pack gzip 105 kB 106 kB ⚠️ +454 B
Overall change 105 kB 106 kB ⚠️ +454 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 62784c1

@lubieowoce lubieowoce changed the title Check if react-dom aliases are correct for edge Fix react-dom RSC aliases for edge Mar 22, 2024
@lubieowoce lubieowoce changed the title Fix react-dom RSC aliases for edge Fix RSC react-dom aliases for edge Mar 22, 2024
@lubieowoce lubieowoce marked this pull request as ready for review March 22, 2024 22:02
@lubieowoce
Copy link
Member Author

This should be good to merge, but I want to do a follow-up to add some tests for edge, because #63588 was all green even though edge was still incorrect. AFAICT, we're basically just not really covering edge in the relevant tests, either for preload() (which broke, revealing issues) or the parts that try to check react{-dom} resolution & versions.

@lubieowoce lubieowoce force-pushed the fix/missing-react-dom-alias-edge branch from 76561de to 62784c1 Compare March 25, 2024 09:53
@ijjk
Copy link
Member

ijjk commented Mar 25, 2024

Tests Passed

@lubieowoce lubieowoce merged commit f509de9 into canary Mar 25, 2024
77 checks passed
@lubieowoce lubieowoce deleted the fix/missing-react-dom-alias-edge branch March 25, 2024 10:37
@github-actions github-actions bot added the locked label Apr 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants