fix(next-core): refine context for unsupported edge imports #63622

kwonoj · 2024-03-22T21:19:15Z

What

Followup for the unsupported imports in edge to inject corresponding context only.

Closes PACK-2824

ijjk · 2024-03-22T21:27:18Z

Failing test suites

Commit: 65e7e27

TURBOPACK=1 pnpm test test/integration/edge-runtime-module-errors/test/module-imports.test.js (turbopack)

Edge runtime code with imports > Edge API statically importing node.js module > throws unsupported module error in dev at runtime and highlights the faulty line

Expand output

● Edge runtime code with imports › Edge API statically importing node.js module › throws unsupported module error in dev at runtime and highlights the faulty line

TIMED OUT: success

undefined

TypeError: body used already for: http://localhost:38749/api/route

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (integration/edge-runtime-module-errors/test/module-imports.test.js:89:7)

Read more about building and testing Next.js in contributing.md.

TURBOPACK=1 pnpm test test/integration/edge-runtime-module-errors/test/index.test.js (turbopack)

Edge runtime code with imports > Edge API dynamically importing node.js module > development mode > throws unsupported module error in dev at runtime and highlights the faulty line
Edge runtime code with imports > Edge API dynamically importing node.js module in a lib > development mode > throws unsupported module error in dev at runtime and highlights the faulty line

Expand output

● Edge runtime code with imports › Edge API dynamically importing node.js module › development mode › throws unsupported module error in dev at runtime and highlights the faulty line

expect(received).toContain(expected) // indexOf

Expected substring: "The edge runtime does not support Node.js 'fs' module"
Received string:    "   ▲ Next.js 14.2.0-canary.39 (turbo)
   - Local:        http://localhost:43181·
Creating turbopack project {
  dir: '/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors',
  testMode: true
}
 ✓ Compiled in 178ms
 ✓ Ready in 1717ms
 ✓ Compiled /api/route in 172ms
 ⨯ test/integration/edge-runtime-module-errors/pages/api/route.js (0:0) @ <unknown>
 ⨯ Error: Cannot find module 'fs'

  at <unknown> (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at handler (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4324:16)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4091:36)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
  at ContextAPI.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:518)
  at NoopTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
  at ProxyTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18854)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4073:103)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062) {
    digest: undefined
  }
    1 |
    2 |           import { NextResponse } from 'next/server'
    3 |
   ○ Compiling /_error ...
   ✓ Compiled /_error in 824ms
   ⨯ test/integration/edge-runtime-module-errors/pages/api/route.js (0:0) @ <unknown>
   ⨯ Error: Cannot find module 'fs'
  at <unknown> (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at handler (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4324:16)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4091:36)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
  at ContextAPI.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:518)
  at NoopTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
  at ProxyTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18854)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4073:103)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062) {
    digest: undefined
  }
    1 |
    2 |           import { NextResponse } from 'next/server'
    3 |
   ⨯ test/integration/edge-runtime-module-errors/pages/api/route.js (0:0) @ <unknown>
   ⨯ Error: Cannot find module 'fs'
  at <unknown> (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at handler (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4324:16)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4091:36)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
  at ContextAPI.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:518)
  at NoopTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
  at ProxyTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18854)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4073:103)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062) {
    digest: undefined
  }
    1 |
    2 |           import { NextResponse } from 'next/server'
    3 |
   ⨯ test/integration/edge-runtime-module-errors/pages/api/route.js (0:0) @ <unknown>
   ⨯ Error: Cannot find module 'fs'
  at <unknown> (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at handler (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4324:16)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4091:36)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
  at ContextAPI.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:518)
  at NoopTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
  at ProxyTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18854)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4073:103)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062) {
    digest: undefined
  }
    1 |
    2 |           import { NextResponse } from 'next/server'
    3 |
   ⨯ test/integration/edge-runtime-module-errors/pages/api/route.js (0:0) @ <unknown>
   ⨯ Error: Cannot find module 'fs'
  at <unknown> (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at handler (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4324:16)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4091:36)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
  at ContextAPI.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:518)
  at NoopTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
  at ProxyTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18854)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4073:103)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062) {
    digest: undefined
  }
    1 |
    2 |           import { NextResponse } from 'next/server'
    3 |
   ⨯ test/integration/edge-runtime-module-errors/pages/api/route.js (0:0) @ <unknown>
   ⨯ Error: Cannot find module 'fs'
  at <unknown> (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at handler (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4324:16)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4091:36)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
  at ContextAPI.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:518)
  at NoopTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
  at ProxyTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18854)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4073:103)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062) {
    digest: undefined
  }
    1 |
    2 |           import { NextResponse } from 'next/server'
    3 |
   ⨯ test/integration/edge-runtime-module-errors/pages/api/route.js (0:0) @ <unknown>
   ⨯ Error: Cannot find module 'fs'
  at <unknown> (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at handler (integration/edge-runtime-module-errors/pages/api/route.js:0:0)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4324:16)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4091:36)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062)
  at ContextAPI.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:518)
  at NoopTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18093)
  at ProxyTracer.startActiveSpan (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:18854)
  at <unknown> (../file:/root/actions-runner/_work/next.js/next.js/test/integration/edge-runtime-module-errors/.next/server/edge/chunks/[project]__6b00c3._.js:4073:103)
  at NoopContextManager.with (../packages/next/dist/compiled/@opentelemetry/api/index.js:1:7062) {
    digest: undefined
  }
    1 |
    2 |           import { NextResponse } from 'next/server'
    3 |
  "
  at toContain (integration/edge-runtime-module-errors/test/utils.js:46:18)
  at expectUnsupportedModuleProdError (integration/edge-runtime-module-errors/test/utils.js:57:3)
  at integration/edge-runtime-module-errors/test/index.test.js:96:42
  at retry (lib/next-test-utils.ts:724:14)
  at Object.<anonymous> (integration/edge-runtime-module-errors/test/index.test.js:93:9)

● Edge runtime code with imports › Edge API dynamically importing node.js module in a lib › development mode › throws unsupported module error in dev at runtime and highlights the faulty line

TIMED OUT: success

undefined

TypeError: body used already for: http://localhost:36413/api/route

  636 |
  637 |   if (hardError) {
> 638 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content + '\n\n' + lastErr)
      |           ^
  639 |   }
  640 |   return false
  641 | }

  at check (lib/next-test-utils.ts:638:11)
  at Object.<anonymous> (integration/edge-runtime-module-errors/test/index.test.js:180:11)

Read more about building and testing Next.js in contributing.md.

pnpm test-start test/e2e/prerender.test.ts (PPR)

Prerender > should on-demand revalidate for fallback: blocking with onlyGenerated if generated

Expand output

● Prerender › should on-demand revalidate for fallback: blocking with onlyGenerated if generated

expect(received).toMatch(expected)

Expected pattern: /(HIT|STALE)/
Received string:  "MISS"

  2294 |
  2295 |         expect(initialTime).toBe($2('#time').text())
> 2296 |         expect(res2.headers.get('x-nextjs-cache')).toMatch(/(HIT|STALE)/)
       |                                                    ^
  2297 |
  2298 |         const res3 = await fetchViaHTTP(
  2299 |           next.url,

  at Object.toMatch (e2e/prerender.test.ts:2296:52)

Read more about building and testing Next.js in contributing.md.

ijjk · 2024-03-22T21:30:34Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
buildDuration	15.7s	15.9s	⚠️ +124ms
buildDurationCached	8.6s	7.4s	N/A
nodeModulesSize	198 MB	198 MB	✓
nextStartRea..uration (ms)	470ms	469ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
2453-HASH.js gzip	30.8 kB	30.8 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	241 B	241 B	✓
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99.3 kB	99.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
index.html gzip	528 B	527 B	N/A
link.html gzip	541 B	539 B	N/A
withRouter.html gzip	524 B	519 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
edge-ssr.js gzip	95.3 kB	95.3 kB	N/A
page.js gzip	3.04 kB	3.04 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
middleware-b..fest.js gzip	627 B	623 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	990 B	990 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
app-page-exp...dev.js gzip	170 kB	170 kB	✓
app-page-exp..prod.js gzip	96.8 kB	96.8 kB	✓
app-page-tur..prod.js gzip	98.5 kB	98.5 kB	✓
app-page-tur..prod.js gzip	92.8 kB	92.8 kB	✓
app-page.run...dev.js gzip	144 kB	144 kB	✓
app-page.run..prod.js gzip	91.3 kB	91.3 kB	✓
app-route-ex...dev.js gzip	21.4 kB	21.4 kB	✓
app-route-ex..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	21 kB	21 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	22.5 kB	22.5 kB	✓
pages.runtim...dev.js gzip	23.1 kB	23.1 kB	✓
pages.runtim..prod.js gzip	22.4 kB	22.4 kB	✓
server.runti..prod.js gzip	50.9 kB	50.9 kB	✓
Overall change	943 kB	943 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js unsupported-edge-context	Change
0.pack gzip	1.57 MB	1.56 MB	N/A
index.pack gzip	106 kB	106 kB	⚠️ +458 B
Overall change	106 kB	106 kB	⚠️ +458 B

Diff details

Diff for middleware.js

Diff too large to display

Commit: fe0e190

ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Mar 22, 2024

kwonoj force-pushed the unsupported-edge-context branch 2 times, most recently from 1516496 to 65e7e27 Compare March 22, 2024 22:25

fix(next-core): refine context for unsupported edge imports

fe0e190

kwonoj force-pushed the unsupported-edge-context branch from 65e7e27 to fe0e190 Compare March 22, 2024 23:35

kwonoj mentioned this pull request Mar 22, 2024

fix(sourcemap): update sourcemap, remove checker vercel/turbo#7823

Merged

sokra approved these changes Mar 23, 2024

View reviewed changes

kwonoj marked this pull request as ready for review March 23, 2024 06:46

kwonoj requested review from timneutkens, ijjk, shuding, huozhi and a team as code owners March 23, 2024 06:46

kwonoj enabled auto-merge (squash) March 23, 2024 06:46

kwonoj merged commit 98ffe45 into canary Mar 23, 2024
77 checks passed

kwonoj deleted the unsupported-edge-context branch March 23, 2024 06:53

github-actions bot added the locked label Apr 6, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(next-core): refine context for unsupported edge imports #63622

fix(next-core): refine context for unsupported edge imports #63622

kwonoj commented Mar 22, 2024 •

edited by padmaia

ijjk commented Mar 22, 2024 •

edited

ijjk commented Mar 22, 2024 •

edited

fix(next-core): refine context for unsupported edge imports #63622

fix(next-core): refine context for unsupported edge imports #63622

Conversation

kwonoj commented Mar 22, 2024 • edited by padmaia

What

ijjk commented Mar 22, 2024 • edited

Failing test suites

ijjk commented Mar 22, 2024 • edited

Stats from current PR

kwonoj commented Mar 22, 2024 •

edited by padmaia

ijjk commented Mar 22, 2024 •

edited

ijjk commented Mar 22, 2024 •

edited