-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fext(next-core): inherit root layout segment config for the routes #63683
Merged
+85
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the turbopack team
type: next
labels
Mar 25, 2024
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display |
Tests Passed |
kwonoj
force-pushed
the
route-root-segment-config
branch
3 times, most recently
from
March 25, 2024 21:48
9c61a1c
to
59596e6
Compare
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
March 25, 2024 22:16
sokra
requested changes
Mar 26, 2024
kwonoj
force-pushed
the
route-root-segment-config
branch
3 times, most recently
from
March 26, 2024 18:16
9aed9a3
to
730a1e9
Compare
kwonoj
force-pushed
the
route-root-segment-config
branch
from
March 27, 2024 16:08
730a1e9
to
1cffb26
Compare
sokra
approved these changes
Mar 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the turbopack team
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Supports root segment config inherit from layout. Currently route segment config only runs agasint own source, so individual route segment config works but if the config is set in layout level it is being ignored. PR introduces root segment and pass into each route if tree level have a corresponding layout.
Closes PACK-2839