fix double redirect when using a loading boundary

[ztanner]

What & Why

When an RSC triggers navigate after the shell has already been sent to the client, a meta tag is inserted to signal to the browser it needs to perform an MPA navigation. This is primarily used for bot user agents, since we wouldn't have been able to provide a proper redirect status code (since it occurred after the initial response was sent).

However, the router would trigger a SPA navigation, while the <meta> tag lagged to perform an MPA navigation, resulting in 2 navigations to the same URL.

How

When the client side code attempts to handle the redirect, we treat it like an MPA navigation. This will suspend in render and trigger a location.push/location.replace to the targeted URL. As a result, only one of these navigation events will win.

Fixes #59800
Fixes #62463
FIxes #57257

Closes NEXT-2952
Closes NEXT-2719

[ztanner]

• fix double redirect when using a loading boundary #63786 👈
• canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite

[ijjk]

Tests Passed

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
buildDuration	14.1s	14s	N/A
buildDurationCached	8.5s	6.5s	N/A
nodeModulesSize	199 MB	199 MB	⚠️ +4.57 kB
nextStartRea..uration (ms)	410ms	409ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
2453-HASH.js gzip	31.4 kB	31.4 kB	N/A
3304.HASH.js gzip	181 B	181 B	✓
3f784ff6-HASH.js gzip	53.7 kB	53.7 kB	✓
8299-HASH.js gzip	5.04 kB	5.04 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	242 B	242 B	✓
main-HASH.js gzip	32.2 kB	32.2 kB	N/A
webpack-HASH.js gzip	1.68 kB	1.68 kB	N/A
Overall change	99.3 kB	99.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
_app-HASH.js gzip	196 B	197 B	N/A
_error-HASH.js gzip	184 B	184 B	✓
amp-HASH.js gzip	505 B	505 B	✓
css-HASH.js gzip	324 B	325 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	258 B	258 B	✓
head-HASH.js gzip	352 B	352 B	✓
hooks-HASH.js gzip	370 B	371 B	N/A
image-HASH.js gzip	4.21 kB	4.21 kB	✓
index-HASH.js gzip	259 B	259 B	✓
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	314 B	312 B	N/A
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	6.57 kB	6.57 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
_buildManifest.js gzip	481 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
index.html gzip	530 B	528 B	N/A
link.html gzip	541 B	540 B	N/A
withRouter.html gzip	525 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
edge-ssr.js gzip	95.3 kB	95.3 kB	N/A
page.js gzip	3.04 kB	3.04 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
middleware-b..fest.js gzip	626 B	626 B	✓
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	25.5 kB	25.5 kB	N/A
edge-runtime..pack.js gzip	839 B	839 B	✓
Overall change	1.62 kB	1.62 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
app-page-exp...dev.js gzip	170 kB	170 kB	N/A
app-page-exp..prod.js gzip	97 kB	97 kB	N/A
app-page-tur..prod.js gzip	98.8 kB	98.8 kB	N/A
app-page-tur..prod.js gzip	93 kB	93 kB	N/A
app-page.run...dev.js gzip	144 kB	144 kB	N/A
app-page.run..prod.js gzip	91.5 kB	91.5 kB	N/A
app-route-ex...dev.js gzip	21.4 kB	21.4 kB	✓
app-route-ex..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	15.1 kB	15.1 kB	✓
app-route-tu..prod.js gzip	14.8 kB	14.8 kB	✓
app-route.ru...dev.js gzip	21 kB	21 kB	✓
app-route.ru..prod.js gzip	14.8 kB	14.8 kB	✓
pages-api-tu..prod.js gzip	9.55 kB	9.55 kB	✓
pages-api.ru...dev.js gzip	9.82 kB	9.82 kB	✓
pages-api.ru..prod.js gzip	9.55 kB	9.55 kB	✓
pages-turbo...prod.js gzip	22.5 kB	22.5 kB	✓
pages.runtim...dev.js gzip	23.1 kB	23.1 kB	✓
pages.runtim..prod.js gzip	22.4 kB	22.4 kB	✓
server.runti..prod.js gzip	51 kB	51 kB	✓
Overall change	250 kB	250 kB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 03-27-fix_double_redirect_when_using_a_loading_boundary	Change
0.pack gzip	1.58 MB	1.58 MB	⚠️ +2.01 kB
index.pack gzip	106 kB	106 kB	⚠️ +222 B
Overall change	1.68 MB	1.69 MB	⚠️ +2.23 kB

Diff details

Diff for middleware.js

Diff too large to display

Diff for 2453-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 7e45177

[JulianJorgensen]

nice! 😍