Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): skip logging non-route requests #63973

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Apr 2, 2024

What?

We should only log route requests and related fetch calls.

Before/After:

Why?

#62946 introduced logging some request information by default, but it is too verbose, logging even requests that are unlikely useful to the user (ie.: _rsc, static asset requests when Middleware is present, etc.)

How?

We have some meta information on requests so we can identify if a request belongs to a route so we can terminate logging early.

Closes NEXT-2977, closes NEXT-2954

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 2, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @balazsorban44 and the rest of your teammates on Graphite Graphite

// don't log again in the router worker.
// we also don't log for middleware alone
if (
(normalizedReq as any).didInvokePath ||
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didInvokePath is not present anywhere in the codebase, likely a remainder of some other code that hasn't been cleaned up properly. (Not using as any here should have caught this.)

@balazsorban44 balazsorban44 marked this pull request as ready for review April 2, 2024 13:21
@ijjk
Copy link
Member

ijjk commented Apr 2, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
buildDuration 14s 14s N/A
buildDurationCached 7.6s 6.4s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 400ms 408ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
index.html gzip 528 B 528 B
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51 kB 51 kB N/A
Overall change 894 kB 894 kB
build cache
vercel/next.js canary vercel/next.js fix/skip-non-route-request-in-log Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 107 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for server.runtime.prod.js

Diff too large to display

Commit: 1e6c669

@ijjk
Copy link
Member

ijjk commented Apr 3, 2024

Tests Passed

@balazsorban44 balazsorban44 merged commit add2e6e into canary Apr 3, 2024
80 checks passed
@balazsorban44 balazsorban44 deleted the fix/skip-non-route-request-in-log branch April 3, 2024 10:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants