Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add telemetry events for ppr & staleTimes experimental flags #63981

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Apr 2, 2024

Adds NextConfig.experimental.ppr and NextConfig.experimental.staletimes to the NEXT_BUILD_FEATURE_USAGE telemetry event.

Closes NEXT-2981

Copy link
Member Author

ztanner commented Apr 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite Graphite

@ztanner ztanner force-pushed the 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags branch 2 times, most recently from 6c13da6 to fdc040f Compare April 2, 2024 15:47
@ijjk
Copy link
Member

ijjk commented Apr 2, 2024

Failing test suites

Commit: 89e40d2

TURBOPACK=1 pnpm test-dev test/e2e/app-dir/asset-prefix/asset-prefix.test.ts (turbopack)

Expand output

● Test suite failed to run

FetchError: request to http://localhost:44999/custom-asset-prefix/_next/static/chunks/app_layout_fd0493.js failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● Test suite failed to run

FetchError: request to http://localhost:44999/custom-asset-prefix/_next/static/chunks/d8b9f_next_dist_esm_build_templates_app-page_d9038d.js failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● Test suite failed to run

FetchError: request to http://localhost:44999/custom-asset-prefix/_next/static/chunks/d8b9f_next_dist_compiled_react_5dff00._.js failed, reason: read ECONNRESET

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● Test suite failed to run

FetchError: request to http://localhost:44999/custom-asset-prefix/_next/static/chunks/_6638fa._.js failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● Test suite failed to run

FetchError: request to http://localhost:44999/custom-asset-prefix/_next/static/chunks/app_page_f775bd.js failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

● Test suite failed to run

FetchError: request to http://localhost:44999/custom-asset-prefix/_next/static/chunks/_eb0c36._.js failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7/node_modules/node-fetch/lib/index.js:1491:11)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Apr 2, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
buildDuration 13.8s 13.8s N/A
buildDurationCached 7.5s 6.1s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +2.6 kB
nextStartRea..uration (ms) 397ms 403ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
index.html gzip 528 B 529 B N/A
link.html gzip 540 B 541 B N/A
withRouter.html gzip 523 B 523 B
Overall change 523 B 523 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51 kB 51 kB
Overall change 945 kB 945 kB
build cache
vercel/next.js canary vercel/next.js 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 89e40d2

@ztanner ztanner force-pushed the 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags branch from fdc040f to 1503cc2 Compare April 2, 2024 16:59
@ztanner ztanner marked this pull request as ready for review April 2, 2024 17:01
@ztanner ztanner force-pushed the 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags branch 2 times, most recently from a7cefe9 to 02fd2fe Compare April 2, 2024 20:22
@ztanner ztanner requested a review from ijjk April 2, 2024 20:23
@ztanner ztanner force-pushed the 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags branch from 02fd2fe to 89e40d2 Compare April 2, 2024 20:31
@ztanner ztanner enabled auto-merge (squash) April 2, 2024 21:04
@ztanner ztanner merged commit eddd1ee into canary Apr 2, 2024
79 checks passed
@ztanner ztanner deleted the 04-02-add_telemetry_events_for_ppr_staleTimes_experimental_flags branch April 2, 2024 21:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants