Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rust-toolchain to nightly-2024-04-03 #64048

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Update rust-toolchain to nightly-2024-04-03 #64048

merged 9 commits into from
Apr 4, 2024

Conversation

wbinnssmith
Copy link
Member

@wbinnssmith wbinnssmith commented Apr 3, 2024 •
edited by padmaia

Depends on vercel/turbo#7874, which should be merged first.

Test Plan: cargo check

Closes PACK-2903

@wbinnssmith
Update rust-toolchain to nightly-2024-04-03
b2304a9 
Depends on vercel/turbo#7874, which should be merged first.

Test Plan: `cargo check`
@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Apr 3, 2024
@wbinnssmith wbinnssmith marked this pull request as ready for review April 3, 2024 23:34
@wbinnssmith wbinnssmith marked this pull request as draft April 3, 2024 23:36
bgw
bgw reviewed Apr 4, 2024
View reviewed changes
test/e2e/app-dir/app-css/index.test.ts Outdated Show resolved Hide resolved
test/e2e/app-dir/app-css/index.test.ts Outdated Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented Apr 4, 2024 •
edited

Tests Passed

@ijjk
Copy link
Member

ijjk commented Apr 4, 2024 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js chore/bump-nightly Change
buildDuration 13.9s 13.8s N/A
buildDurationCached 7.5s 6.1s N/A
nodeModulesSize 199 MB 199 MB ✓
nextStartRea..uration (ms) 399ms 404ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js chore/bump-nightly Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/bump-nightly Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js chore/bump-nightly Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js chore/bump-nightly Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/bump-nightly Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 523 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js chore/bump-nightly Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js chore/bump-nightly Change
middleware-b..fest.js gzip 626 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js chore/bump-nightly Change
app-page-exp...dev.js gzip 170 kB 170 kB ✓
app-page-exp..prod.js gzip 97 kB 97 kB ✓
app-page-tur..prod.js gzip 98.8 kB 98.8 kB ✓
app-page-tur..prod.js gzip 93 kB 93 kB ✓
app-page.run...dev.js gzip 144 kB 144 kB ✓
app-page.run..prod.js gzip 91.5 kB 91.5 kB ✓
app-route-ex...dev.js gzip 21.4 kB 21.4 kB ✓
app-route-ex..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route.ru...dev.js gzip 21.1 kB 21.1 kB ✓
app-route.ru..prod.js gzip 14.9 kB 14.9 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 51.1 kB 51.1 kB ✓
Overall change 945 kB 945 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/bump-nightly Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 107 kB ⚠️ +179 B
Overall change 106 kB 107 kB ⚠️ +179 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 424852d

@wbinnssmith wbinnssmith marked this pull request as ready for review April 4, 2024 21:54
@wbinnssmith wbinnssmith requested review from a team as code owners April 4, 2024 21:54
@wbinnssmith wbinnssmith requested review from manovotny and leerob and removed request for a team April 4, 2024 21:54
@wbinnssmith
Copy link
Member Author

@kwonoj this disables the wasi check for now while we wait on napi-rs to catch up to nightly. cc @Brooooooklyn

@wbinnssmith wbinnssmith enabled auto-merge (squash) April 4, 2024 23:13
@wbinnssmith wbinnssmith merged commit 3d3311b into canary Apr 4, 2024
75 of 80 checks passed
@wbinnssmith wbinnssmith deleted the chore/bump-nightly branch April 4, 2024 23:28
epiloguess pushed a commit to epiloguess/next.js that referenced this pull request Apr 5, 2024
@wbinnssmith @epiloguess
Update rust-toolchain to nightly-2024-04-03 (vercel#64048)
abde81f 
Depends on vercel/turbo#7874, which should be
merged first.

Test Plan: `cargo check`


Closes PACK-2903
@Brooooooklyn
Copy link
Contributor

@wbinnssmith napi-rs cli published: https://github.com/napi-rs/napi-rs/releases/tag/%40napi-rs%2Fcli%403.0.0-alpha.46

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bgw bgw bgw approved these changes

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

@kwonoj kwonoj Awaiting requested review from kwonoj

@sokra sokra Awaiting requested review from sokra

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang

@manovotny manovotny Awaiting requested review from manovotny manovotny is a code owner automatically assigned from vercel/devex

@leerob leerob Awaiting requested review from leerob leerob is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wbinnssmith @ijjk @Brooooooklyn @bgw @ForsakenHarmony