test(turbopack): Add -Wl,--warn-unresolved-symbols to next-swc-napi on Linux #64049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgw
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
kdy1
approved these changes
Apr 4, 2024
bgw
force-pushed
the
bgw/napi-unresolved-symbols
branch
from
f0ed4d9
to
eabbddb
Compare
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for middleware.jsDiff too large to display |
|
This breaks wasi builds with I'll exclude wasm32 and update this. |
…n Linux I'm not sure why this issue is impacting me and seemingly not others, but on Debian 12 with the default linker options (gcc with ld) I get the following compilation error regarding unresolved symbols: https://gist.github.com/bgw/92da94f46b0994514a144b8938aa2f6c This flag downgrades that linker error to a warning (which cargo hides). I've checked that this flag is supported by ld, gold, lld, and mold. I've also tried building with mold in addition to ld. I'm restricting the option to linux to avoid potentially breaking other platforms. Tested by running: ``` cargo test -p next-swc-napi ``` Which now gives: ``` running 2 tests test transform::test_deserialize_transform_regenerator ... ok test transform::test_deser ... ok ```
bgw
force-pushed
the
bgw/napi-unresolved-symbols
branch
from
eabbddb
to
c9a157d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why this issue is impacting me and seemingly not others, but on Debian 12 with the default linker options (gcc with ld) I get the following compilation error regarding unresolved symbols:
https://gist.github.com/bgw/92da94f46b0994514a144b8938aa2f6c
This flag downgrades that linker error to a warning (which cargo hides).
I've checked that this flag is supported by ld, gold, lld, and mold. I've also tried building with mold in addition to ld. I'm restricting the option to linux to avoid potentially breaking other platforms.
Tested by running:
Which now gives: