Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure configuration is checked for Turbopack build #64247

Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Apr 9, 2024

What?

Currently any configuration issue like including .babelrc was not highlighted during Turbopack build. This PR solves that issue as well as ensuring the warnings are not double-logged because of a change that was supposed to be development-only.

Closes NEXT-3049

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Apr 9, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Apr 9, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
buildDuration 14s 14s N/A
buildDurationCached 7.5s 6.4s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +10 kB
nextStartRea..uration (ms) 402ms 403ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.05 kB 5.05 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.22 kB 4.22 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 2.36 kB 2.36 kB
Client Build Manifests
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
index.html gzip 530 B 528 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 525 B 523 B N/A
Overall change 542 B 542 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
edge-ssr.js gzip 95.5 kB 95.5 kB N/A
page.js gzip 3.06 kB 3.06 kB
Overall change 3.06 kB 3.06 kB
Middleware size
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
middleware-b..fest.js gzip 624 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97.3 kB 97.3 kB
app-page-tur..prod.js gzip 99.1 kB 99.1 kB
app-page-tur..prod.js gzip 93.3 kB 93.3 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.8 kB 91.8 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.3 kB 51.3 kB
Overall change 947 kB 947 kB
build cache
vercel/next.js canary vercel/next.js 04-09-Ensure_configuration_is_checked_for_Turbopack_build Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 107 kB 106 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 87a5bec

@timneutkens timneutkens marked this pull request as draft April 9, 2024 09:50
@timneutkens timneutkens marked this pull request as ready for review April 10, 2024 06:27
@timneutkens timneutkens merged commit 4c128a5 into canary Apr 10, 2024
79 checks passed
@timneutkens timneutkens deleted the 04-09-Ensure_configuration_is_checked_for_Turbopack_build branch April 10, 2024 08:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants