Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure externals is undefined or false for client compilation #6946

Closed
timneutkens opened this issue Apr 8, 2019 · 0 comments · Fixed by #6983
Closed

Make sure externals is undefined or false for client compilation #6946

timneutkens opened this issue Apr 8, 2019 · 0 comments · Fixed by #6983
Assignees

Comments

@timneutkens
Copy link
Member

Currently client compilation or serverless target will have:

[
      // When the serverless target is used all node_modules will be compiled into the output bundles
      // So that the serverless bundles have 0 runtime dependencies
      'amp-toolbox-optimizer' // except this one
    ]

However this is not needed for client compilation. Meaning it should be set to undefined or false to opt-out of adding the ExternalsPlugin:

https://github.com/webpack/webpack/blob/7ed1a8f/lib/WebpackOptionsApply.js#L206-L212

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants