Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outdir line in typescript customer server example creates additional directory on build #7347

Closed
mrispoli24 opened this issue May 15, 2019 · 2 comments · Fixed by #7362
Closed

outdir line in typescript customer server example creates additional directory on build #7347

mrispoli24 opened this issue May 15, 2019 · 2 comments · Fixed by #7362
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@mrispoli24
Copy link
Contributor

mrispoli24 commented May 15, 2019 •
edited

Bug report

I believe that the outdir line in the with typescript custom server example creates your server in .next/server/server which makes the production build and start commands as they stand break. You can remove this and the /server directory will build as intended or update the start script to node .next/server/server. I just removed that line from my project and all built as intended.
@mrispoli24 mrispoli24 changed the title outdir line creates additional /server path on build not necessary outdir line in typescript customer server example creates additional directory on build May 15, 2019
@timneutkens timneutkens added good first issue Easy to fix issues, good for newcomers help wanted labels May 16, 2019
@timneutkens
Copy link
Member

Feel free to send a pull request.

@mrispoli24
Copy link
Contributor Author

Thanks @timneutkens sent one over for you here: #7362

@mrispoli24 mrispoli24 mentioned this issue May 16, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove outdir line from tsconfig.server.json mrispoli24/next.js
2 participants
@mrispoli24 @timneutkens