AMP is not working with Material-UI

[dmdb]

Examples bug report

Example name

https://github.com/mui-org/material-ui/tree/master/examples/nextjs

Describe the bug

If you turn on AMP-first on a page, for example on about page:

You will get error

To Reproduce

1. Follow instructions https://github.com/mui-org/material-ui/tree/master/examples/nextjs
2. Enable AMP on page
3. Open it
4. See error

Expected behavior

AMP is working fine with Material UI

System information

• OS: Ubuntu 18.04
• Chrome
• Next.js 9.1.1, MaterialUI 4.5.0

Additional context

It maybe problem with material-ui example or other styling integrations. Here is some similar as I think issues:
#7856
mui/material-ui#17784

[Janpot]

@dmdb FYI, in case you want to pick this up, an effort to fix this was started in #7954, I'm not 100% sure where this should be headed, but I guess the with-typescript-styled-components` example should be updated to use

        styles: [
          ...React.Children.toArray(initialProps.styles),
          ...sheet.getStyleElement(),
        ],

to make it work and compliant with the types. I can only guess that the same kind of setup was used in other CSS-in-JS examples and will have the same incompatibilities with AMP.

[dmdb]

@Janpot Unfortunately I'am not quite confident to pick it, I've just monkey-patched it in our project (thanks to @tomevans18) with

It seems works fine, but not sure why 🤷‍♀️
Anyway it seems that it is a common problem with example and should be fixed somehow in proper, official way.

PS. Thanks for AMP support on Next.js team. It is a huge benefit

[oliviertassinari]

We have updated Material-UI's examples to work with Next.js and AMP, and now waiting on mui/material-ui#18044 to solve the TypeScript part of it.

[derolf]

I am trying to get nextjs with amp and material-ui to work, but the styles don’t get included in amp mode (works in non-amp mode). Is there any minimal example?

[KyruCabading]

@oliviertassinari saw this and wanted to mention that NextJS has a custom Html component within next/document that might be what's missing for AMP support. One of our devs noticed that new component in a NextJS MUI PR

If you look at docs here, there's a new Html component to use within _document.js
https://nextjs.org/docs/advanced-features/custom-document

And that component adds an amp prop which is required for AMP support.
https://github.com/zeit/next.js/blob/canary/packages/next/pages/_document.tsx#L138-L165

https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml/

We can add it in if you'd like

[oliviertassinari]

@KyruCabading As far as I know, we have fixed this issue, it can be closed.

[timneutkens]

Opened mui/material-ui#20463, good catch @KyruCabading

[oliviertassinari]

@timneutkens Thanks, we are making progress:

---

However, when I try to render this page

import React from 'react';
import TextField from '@material-ui/core/TextField';

export default function BasicTextFields() {
  return (
    <div>
      <TextField id="standard-basic" label="Standard" />
    </div>
  );
}

export const config = { amp: true }

I get the following error:

Creating an optimized production build

Compiled successfully.

Amp Validation

/  error  The text inside tag 'style amp-custom (transformed)' contains 'CSS !important', which is disallowed.  https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#stylesheets
   error  The text inside tag 'style amp-custom (transformed)' contains 'CSS !important', which is disallowed.  https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#stylesheets
   error  The text inside tag 'style amp-custom (transformed)' contains 'CSS !important', which is disallowed.  https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#stylesheets
   error  The text inside tag 'style amp-custom (transformed)' contains 'CSS !important', which is disallowed.  https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#stylesheets


> Build error occurred
Error: AMP Validation caused the export to fail. https://err.sh/zeit/next.js/amp-export-validation

I'm investigating.

[timneutkens]

cc @sebastianbenz

[oliviertassinari]

Found it https://github.com/mui-org/material-ui/blob/cc3b03becb98902b027026081e01832b009e7507/packages/material-ui/src/InputBase/InputBase.js#L25

[oliviertassinari]

It works if I comment the !important. I will see if we can work around it in the core. The only concern I have left is that we rely on the React runtime to update the styles on focus. We lose this visual feedback.

import React from 'react';
import TextField from '@material-ui/core/TextField';

export default function BasicTextFields() {
  return (
    <div>
        <TextField InputLabelProps={{shrink: true}} id="standard-basic" label="Standard" />
        <TextField InputLabelProps={{shrink: true}} id="filled-basic" label="Filled" variant="filled" />
        <TextField InputLabelProps={{shrink: true}} id="outlined-basic" label="Outlined" variant="outlined" />
    </div>
  );
}

export const config = { amp: true }

[oliviertassinari]

We use !important to fix an issue with Edge. We have an alternative solution at mui/material-ui#15183 (comment) but I'm not sure it's worth fixing. I propose we wait to see users' requests for it.

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.