Custom amphtml-validator for invalid amp

[yosuke-furukawa]

Feature request

I would like to customize amphtml validator.
our project are using amp html, and we would like to customize our own amp validator.

Is your feature request related to a problem? Please describe.

Currently next.js worker uses buit-in amphtml-validator.
https://github.com/zeit/next.js/blob/canary/packages/next/export/worker.js#L6
https://github.com/zeit/next.js/blob/canary/packages/next/export/worker.js#L151

However amphtml-validator has options to customize validators in here. https://github.com/ampproject/amphtml/blob/master/validator/nodejs/index.js#L295

We would like to inject the custom validators using this options.

If next.js could pass the options, that is really helpful.

const validateAmp = async (html, page, validatorPath) => {
  const validator = await AmpHtmlValidator.getInstance(validatorPath)
  const result = validator.validateString(html)
  // ...
}

Describe the solution you'd like

Add validator options in worker.js.

Describe alternatives you've considered

N/A

Additional context

Related issues:
#9164
#8389

[yosuke-furukawa]

I will try to send PR later.

[timneutkens]

@yosuke-furukawa this doesn't explain the "why" you'd want to do that. Can you elaborate on that?

[yosuke-furukawa]

@timneutkens
We have 2 reasons of that.

1. We are creating an AMP application but the application does not follow whole AMP rules currently. i.e, we would like to create AMP but it is not valid AMP now. if we could change the whole situation (such as analytics, advertisement, etc), we could create valid AMP. So currently we would like to attach AMP validation rules gradually.

2. Default AMP validator downloads the scripts from CDN, we would like to use the fixed version script to lock versions.

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.