Change example link to be equal to query property #10052

lcandiago · 2020-01-12T12:52:52Z

The example uses { name: 'ZEIT' } but then say that it will link to ?name=Zeit.

The example uses { name: 'ZEIT' } but then say that it will link to `?name=Zeit`.

ijjk · 2020-01-12T12:59:07Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	lcandiago/next.js patch-2	Change
buildDuration	13.1s	12.9s	-165ms
nodeModulesSize	49 MB	49 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	lcandiago/next.js patch-2	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode

General

	zeit/next.js canary	lcandiago/next.js patch-2	Change
buildDuration	13.4s	13.4s	⚠️ +29ms
nodeModulesSize	49 MB	49 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_error.js gzip	77.8 kB	77.8 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	✓
link.js gzip	80.4 kB	80.4 kB	✓
routerDirect.js gzip	78.1 kB	78.1 kB	✓
withRouter.js gzip	78.1 kB	78.1 kB	✓
Overall change	393 kB	393 kB	✓

Commit: 9b96132

ijjk · 2020-01-12T19:20:59Z

Stats from current PR

Default Server Mode

General

	zeit/next.js canary	lcandiago/next.js patch-2	Change
buildDuration	14.1s	13.6s	-452ms
nodeModulesSize	49 MB	49 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Rendered Page Sizes

	zeit/next.js canary	lcandiago/next.js patch-2	Change
index.html gzip	1.02 kB	1.02 kB	✓
link.html gzip	1.03 kB	1.03 kB	✓
withRouter.html gzip	1.01 kB	1.01 kB	✓
Overall change	3.06 kB	3.06 kB	✓

Serverless Mode

General

	zeit/next.js canary	lcandiago/next.js patch-2	Change
buildDuration	14.5s	14.4s	-85ms
nodeModulesSize	49 MB	49 MB	✓

Client Bundles (main, webpack, commons)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.js gzip	5.11 kB	5.11 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..54d3.js gzip	4.68 kB	4.68 kB	✓
commons.HASH.js gzip	4.06 kB	4.06 kB	✓
de003c3a9d30..9881.js gzip	13.7 kB	13.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	67.5 kB	67.5 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
main-HASH.module.js gzip	4.18 kB	4.18 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
4952ddcd88e7..dule.js gzip	5.56 kB	5.56 kB	✓
de003c3a9d30..dule.js gzip	12.5 kB	12.5 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	62.1 kB	62.1 kB	✓

Legacy Client Bundles (polyfills)

	zeit/next.js canary	lcandiago/next.js patch-2	Change
polyfills-HASH.js gzip	4.76 kB	4.76 kB	✓
Overall change	4.76 kB	4.76 kB	✓

Client Pages

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.js gzip	1.33 kB	1.33 kB	✓
_error.js gzip	4.07 kB	4.07 kB	✓
hooks.js gzip	779 B	779 B	✓
index.js gzip	222 B	222 B	✓
link.js gzip	2.9 kB	2.9 kB	✓
routerDirect.js gzip	283 B	283 B	✓
withRouter.js gzip	282 B	282 B	✓
Overall change	9.87 kB	9.87 kB	✓

Client Pages Modern

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_app.module.js gzip	757 B	757 B	✓
_error.module.js gzip	3.06 kB	3.06 kB	✓
hooks.module.js gzip	371 B	371 B	✓
index.module.js gzip	212 B	212 B	✓
link.module.js gzip	2.47 kB	2.47 kB	✓
routerDirect..dule.js gzip	273 B	273 B	✓
withRouter.m..dule.js gzip	272 B	272 B	✓
Overall change	7.41 kB	7.41 kB	✓

Client Build Manifests

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_buildManifest.js gzip	61 B	61 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	122 B	122 B	✓

Serverless bundles

	zeit/next.js canary	lcandiago/next.js patch-2	Change
_error.js gzip	77.8 kB	77.8 kB	✓
hooks.html gzip	1.05 kB	1.05 kB	✓
index.js gzip	78 kB	78 kB	✓
link.js gzip	80.4 kB	80.4 kB	✓
routerDirect.js gzip	78.1 kB	78.1 kB	✓
withRouter.js gzip	78.1 kB	78.1 kB	✓
Overall change	393 kB	393 kB	✓

Commit: 11ff8a0

Change example link to be equal to query property

9b96132

The example uses { name: 'ZEIT' } but then say that it will link to `?name=Zeit`.

lcandiago requested a review from Timer as a code owner January 12, 2020 12:52

Merge branch 'canary' into patch-2

11ff8a0

ijjk approved these changes Jan 12, 2020

View reviewed changes

ijjk merged commit 3096a77 into vercel:canary Jan 12, 2020

snyk-bot mentioned this pull request Feb 11, 2020

[Snyk] Upgrade next from 9.1.5 to 9.2.0 ndom91/newtelco-next-maintenance-mgmt#16

Merged

vercel locked as resolved and limited conversation to collaborators Jan 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change example link to be equal to query property #10052

Change example link to be equal to query property #10052

lcandiago commented Jan 12, 2020

ijjk commented Jan 12, 2020

ijjk commented Jan 12, 2020

Change example link to be equal to query property #10052

Change example link to be equal to query property #10052

Conversation

lcandiago commented Jan 12, 2020

ijjk commented Jan 12, 2020

Stats from current PR

ijjk commented Jan 12, 2020

Stats from current PR