Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid href error message #17183

Merged
merged 3 commits into from Sep 18, 2020
Merged

Fix invalid href error message #17183

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74ee052
Fix invalid href error message
sdornan Sep 17, 2020
54ce20a
Merge branch 'canary' into patch-1
sdornan Sep 17, 2020
af3f3c5
Merge branch 'canary' into patch-1
kodiakhq[bot] Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions errors/invalid-href-passed.md
View file
Open in desktop
Expand Up @@ -7,8 +7,7 @@ When using any of these, it is expected they are only used for internal navigati

Either you passed a non-internal `href` to a `next/link` component or you called `Router#push` or `Router#replace` with one.

Invalid `href`s include external sites (https://google.com) and `mailto:` links. In the past, usage of these invalid `href`s could have gone unnoticed but since they can cause unexpected behavior.
We now show a warning in development for them.
Invalid `href`s include external sites (https://google.com) and `mailto:` links. In the past, usage of these invalid `href`s could have gone unnoticed, but since they can cause unexpected behavior we now show a warning in development for them.

#### Possible Ways to Fix It

Expand Down