Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless getComputedStyle call. #27969

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Remove useless getComputedStyle call. #27969

merged 4 commits into from
Sep 20, 2021

Commits on Aug 11, 2021

  1. Remove useless getComputedStyle call.

    See w3c/csswg-drafts#6501 to see how I found this.
    
    This line doesn't recompute layout in browsers, because `"height"` is given as a pseudo-element name rather than a property.
    
    The right way to do what it wants is `getComputedStyle(document.body).height`, but given nobody noticed this (and this is generally never needed, manually triggering layout should never be needed to avoid FOUC) it seems better to keep current behavior and just remove the call.
    emilio committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    da3ef16 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2021

  1. Configuration menu
    Copy the full SHA
    d978728 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2021

  1. Configuration menu
    Copy the full SHA
    2b66b7b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Configuration menu
    Copy the full SHA
    28f90b0 View commit details
    Browse the repository at this point in the history