Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(create-next-app): simplify import alias validation logic #45241

Merged
merged 3 commits into from
Jan 25, 2023
Merged

refactor(create-next-app): simplify import alias validation logic #45241

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d1b3a8
simplify import alias logic
juliusmarminge Jan 24, 2023
c45a640
fix: typo
juliusmarminge Jan 24, 2023
a090301
Merge branch 'canary' into import-alias
kodiakhq[bot] Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 12 additions & 24 deletions packages/create-next-app/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,30 +342,18 @@ async function run(): Promise<void> {
if (ciInfo.isCI) {
program.importAlias = '@/*'
} else {
let importAlias = ''

const promptAlias = async () => {
const styledImportAlias = chalk.hex('#007acc')('import alias')
const promptResult = await prompts({
onState: onPromptState,
type: 'text',
name: 'importAlias',
message: `What ${styledImportAlias} would you like configured?`,
initial: getPrefOrDefault('importAlias'),
})
importAlias = promptResult.importAlias

if (!/.+\/\*/.test(importAlias)) {
console.error(
`${chalk.red(
'Error:'
)} invalid import alias (${importAlias}), it must follow the pattern <prefix>/*`
)
await promptAlias()
}
}
await promptAlias()

const styledImportAlias = chalk.hex('#007acc')('import alias')
const { importAlias } = await prompts({
onState: onPromptState,
type: 'text',
name: 'importAlias',
message: `What ${styledImportAlias} would you like configured?`,
initial: getPrefOrDefault('importAlias'),
validate: (value) =>
/.+\/\*/.test(value)
? true
: 'Import alias must follow the pattern <prefix>/*',
})
program.importAlias = importAlias
preferences.importAlias = importAlias
}
Expand Down